From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D2EC433ED for ; Mon, 10 May 2021 14:39:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 366FB60241 for ; Mon, 10 May 2021 14:39:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343494AbhEJOjL (ORCPT ); Mon, 10 May 2021 10:39:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:52668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233750AbhEJOg6 (ORCPT ); Mon, 10 May 2021 10:36:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 60A5161260; Mon, 10 May 2021 14:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620657353; bh=7+rmrDDH4A6uYJ58L9mxQLde2wCS0ipr0v/8oSvfwtc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qFxZW0z9w0jusStjICTPl/aKhGOUWUVyJDALZOW+6CG+PRlrWU8tMS8RQAc2fGXLP ZtV70ikvOz5Htse0Q8nRb7lRL1wEhB3DhVn8xLFydH2UJ+xcsamc29MyxR9e1C646W GGzLZCZ7cnPBoWisLWKQX9Mw/SDTqGHFDbLE9Zczzm5WZwAkSejdIpZm3xNfPSuM7g 51FU5FVUufLz/TTftQca3HRTevyP1H48CJE+VtRBrQrDSv8EhUYLFCf8HFUqTdHtkj auSs8GTiTrLayQvxTmZfj+nWrinqjn9Hxl5wsEfOHcNtPPX54Ps062Mh3IQ9I1VVjB VtPfKzCpxYUlg== Date: Mon, 10 May 2021 07:35:51 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst Message-ID: References: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> <157988c7-079f-0c9f-5cf9-e83bc2f835d1@huawei.com> <6d574f4e-fed2-ded8-c9d5-4d88bff5d584@huawei.com> <3f7ebf46-536e-dc80-ebda-71b2034cb4c9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f7ebf46-536e-dc80-ebda-71b2034cb4c9@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10, Chao Yu wrote: > On 2021/4/22 14:07, Chao Yu wrote: > > On 2021/4/22 11:59, Jaegeuk Kim wrote: > > > On 04/21, Chao Yu wrote: > > > > On 2021/3/11 4:52, Jaegeuk Kim wrote: > > > > > On 03/09, Chao Yu wrote: > > > > > > On 2021/3/9 8:01, Jaegeuk Kim wrote: > > > > > > > On 03/05, Chao Yu wrote: > > > > > > > > On 2021/3/5 4:20, Jaegeuk Kim wrote: > > > > > > > > > On 02/27, Jaegeuk Kim wrote: > > > > > > > > > > On 02/04, Chao Yu wrote: > > > > > > > > > > > Jaegeuk, > > > > > > > > > > > > > > > > > > > > > > On 2021/2/2 16:00, Chao Yu wrote: > > > > > > > > > > > > - for (i = 0; i < dic->nr_cpages; i++) { > > > > > > > > > > > > + for (i = 0; i < cc->nr_cpages; i++) { > > > > > > > > > > > > struct page *page = dic->cpages[i]; > > > > > > > > > > > > > > > > > > > > > > por_fsstress still hang in this line? > > > > > > > > > > > > > > > > > > > > I'm stuck on testing the patches, since the latest kernel is panicking somehow. > > > > > > > > > > Let me update later, once I can test a bit. :( > > > > > > > > > > > > > > > > > > It seems this works without error. > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 > > > > > > > > > > > > > > > > Ah, good news. > > > > > > > > > > > > > > > > Thanks for helping to test the patch. :) > > > > > > > > > > > > > > Hmm, I hit this again. Let me check w/o compress_cache back. :( > > > > > > > > > > > > Oops :( > > > > > > > > > > Ok, apprantely that panic is caused by compress_cache. The test is running over > > > > > 24hours w/o it. > > > > > > > > Jaegeuk, > > > > > > > > I'm still struggling troubleshooting this issue. > > > > > > > > However, I failed again to reproduce this bug, I doubt the reason may be > > > > my test script and environment(device type/size) is different from yours. > > > > (btw, I used pmem as back-end device, and test w/ all fault injection > > > > points and w/o write_io/checkpoint fault injection points) > > > > > > > > Could you please share me your run.sh script? and test command? > > > > > > > > And I'd like to ask what's your device type and size? > > > > > > I'm using qemu with 16GB with this script. > > > https://github.com/jaegeuk/xfstests-f2fs/blob/f2fs/run.sh > > > > > > ./run.sh por_fsstress > > > > Thanks, let me check the difference, and try again. > > Finally, I can reproduce this bug, and after troubleshooting this > issue, I guess the root cause is not related to this patch, could > you please test patch "f2fs: compress: fix race condition of overwrite > vs truncate" with compress_cache enabled? I've ran por_fsstress case > for 6 hours w/o any problems. Good, sure. :) > > Thanks, > > > > > Thanks, > > > > > > > > > > > > > Thanks, > > > > > > > > > . > > > > > > > > . > > > > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > . > >