From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4318C433B4 for ; Tue, 11 May 2021 11:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7AA26192A for ; Tue, 11 May 2021 11:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231383AbhEKLT5 (ORCPT ); Tue, 11 May 2021 07:19:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:39246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230401AbhEKLTz (ORCPT ); Tue, 11 May 2021 07:19:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 19CD561363; Tue, 11 May 2021 11:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620731929; bh=3965pDIxL3ePZ2py6vgy+3FF19ziZfQsspyiY3RjjYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HEWeDWBkJCFFXTbE3xs724vpb7eYa3LrCSF3Lw+g8mQbYRHwjddabjl6rV11nKyAe 5ZMT4xYx5cZMXxOfzugimPrQu9LsBYDU+sNoqmR7ioRzQkft4tb3zf9La0JY3ZTswg 6X0SsIB6Zmn8sLkCCanPzVzlqcUQl658fBP+P4tci3n0ZenMJmtDAuhOKvwG06lCuS avfcmU5dxkJo91JTv6x0xxyPswG6zwHqUfEEfUQPsBm+hv0deDT8dtFDf/zEb/HKG+ 2P6j/loU6mCA+MWk7Q6WJNjSy8UwqWj4g0juHYqcH8iwCgR7VX+e7UXb1fhttdqAe9 Kl+6KefOpCu1g== Date: Tue, 11 May 2021 16:48:45 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, amit.pundir@linaro.org Subject: Re: [PATCH] soundwire: qcom: fix handling of qcom,ports-block-pack-mode Message-ID: References: <20210504125909.16108-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210504125909.16108-1-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04-05-21, 13:59, Srinivas Kandagatla wrote: > Support to "qcom,ports-block-pack-mode" was added at later stages > to support a variant of Qualcomm SoundWire controllers available > on Apps processor. However the older versions of the SoundWire > controller which are embedded in WCD Codecs do not need this property. > > So returning on error for those cases will break boards like DragonBoard > DB845c and Lenovo Yoga C630. > > This patch fixes error handling on this property considering older usecases. Applied, thanks -- ~Vinod