From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81589C433ED for ; Thu, 13 May 2021 09:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 415056143A for ; Thu, 13 May 2021 09:48:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232525AbhEMJtx (ORCPT ); Thu, 13 May 2021 05:49:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:50286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhEMJth (ORCPT ); Thu, 13 May 2021 05:49:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9FC1613D6; Thu, 13 May 2021 09:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620899308; bh=ZdufSwHQhI6UqGmsnop72bTBK3b9KB9yklyAwI+MobQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PtIs6Vd3YiZ3ikcQVWaY1c/EN4Qm+dANzcM79dwtMTdnKz8S5EdPEs2kwRaTWXKue 82umZ2oCxobcgz6danlIVuX5RXrIbuQ8cwny0XGsst99B1iAYK60YcbKvDv3uIbI1f zFy1dNqLKjLBYb5eeajJwphaeEvpiWspzitc6EWY= Date: Thu, 13 May 2021 11:48:25 +0200 From: Greg Kroah-Hartman To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 5.10 050/530] md: md_open returns -EBUSY when entering racing area Message-ID: References: <20210512144819.664462530@linuxfoundation.org> <20210512144821.386618889@linuxfoundation.org> <20210513075940.GA22156@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 11:47:15AM +0200, Greg Kroah-Hartman wrote: > On Thu, May 13, 2021 at 09:59:41AM +0200, Pavel Machek wrote: > > Hi! > > > > > commit 6a4db2a60306eb65bfb14ccc9fde035b74a4b4e7 upstream. > > > > > > commit d3374825ce57 ("md: make devices disappear when they are no longer > > > needed.") introduced protection between mddev creating & removing. The > > > md_open shouldn't create mddev when all_mddevs list doesn't contain > > > mddev. With currently code logic, there will be very easy to trigger > > > soft lockup in non-preempt env. > > > > > > This patch changes md_open returning from -ERESTARTSYS to -EBUSY, which > > > will break the infinitely retry when md_open enter racing area. > > > > > > This patch is partly fix soft lockup issue, full fix needs mddev_find > > > is split into two functions: mddev_find & mddev_find_or_alloc. And > > > md_open should call new mddev_find (it only does searching job). > > > > > > For more detail, please refer with Christoph's "split mddev_find" patch > > > in later commits. > > > > Something went wrong here; changelog is truncated, in particular it > > does not contain required sign-offs. > > That's really odd, let me figure out what went wrong there, might be a > quilt thing... Yup, it's a bug in quilt, the header is just dropped for some reason. Will dig further, thanks for pointing this out. greg k-h