From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26723C4707F for ; Thu, 27 May 2021 19:02:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A0F6613DC for ; Thu, 27 May 2021 19:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236606AbhE0TDt (ORCPT ); Thu, 27 May 2021 15:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236140AbhE0TDN (ORCPT ); Thu, 27 May 2021 15:03:13 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA5CC061761; Thu, 27 May 2021 12:01:39 -0700 (PDT) Received: from zn.tnic (p200300ec2f0f02007e50b358e2406320.dip0.t-ipconnect.de [IPv6:2003:ec:2f0f:200:7e50:b358:e240:6320]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 05AE51EC01DF; Thu, 27 May 2021 21:01:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622142097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=3McnNCepB5hW/fju+vVEoOY+HqLuey0+yRIpnzxlez8=; b=BQ3DtOWZmcw2ASN1yYM0XjgySvZ2JuWGx5TB1e7aQFx3lFDZzauJQ4xr5m/3soSaMkrG+b K23V3prSqm1wCykboY6Z/V1DuQinqBcdQLVtaKwS2Y9YC5hiHJcZc8LNXiKz/obMfIyyN9 iEZpMgNjNzwUhFOuvcmv0r1jG2MYTnI= Date: Thu, 27 May 2021 21:01:35 +0200 From: Borislav Petkov To: Srinivas Pandruvada Cc: Borislav Petkov , James Feeney , linux-smp@vger.kernel.org, Jens Axboe , lkml , Zhang Rui , x86-ml Subject: Re: [PATCH] x86/thermal: Fix LVT thermal setup for SMI delivery mode Message-ID: References: <373464e3-b8a0-0fe0-b890-41df0eecf090@nurealm.net> <1f6c70f4-6680-d6ea-465a-548dc7698317@nurealm.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 11:09:59AM -0700, Srinivas Pandruvada wrote: > My guess is that system is booting hot sometimes. SMM started fan or > some cooling and set a temperature threshold. It is waiting for thermal > interrupt for temperature threshold, which it never got. Are you saying that that replication of lvtthmr_init to the APs in intel_init_thermal() is absolutely needed on those SMI machines running hot? That thing: * If BIOS takes over the thermal interrupt and sets its interrupt * delivery mode to SMI (not fixed), it restores the value that the * BIOS has programmed on AP based on BSP's info we saved since BIOS * is always setting the same value for all threads/cores. ? Me moving that lvtthmr_init read later would replicate the wrong value because we'd soft-disable the APIC and thus the core would lockup waiting... The other interesting thing is that the core would always lockup when trying to IPI another core to remote-flush the TLBs. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette