From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F92C4707F for ; Thu, 27 May 2021 14:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73A7A60C40 for ; Thu, 27 May 2021 14:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236557AbhE0OxX (ORCPT ); Thu, 27 May 2021 10:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235134AbhE0OxP (ORCPT ); Thu, 27 May 2021 10:53:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58691C061574; Thu, 27 May 2021 07:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=npPt/wweDD4gAB4M4/7EGJsgjBLetKg+ztbe714ojBI=; b=OFjWhLUkQrqv2SnNjS8xOO9wI2 AMs5Ygrsa+ZgSvyCvnHpZwTIX8sH7eQSlZyqVAaMthIQ1449j49eiH+OiNIIEE5ivHZbK8EpsvZvn kDeWsEa6amY3VJaPkCsu6OQx0mzSAeG+/wh3Tshe5rTa2dPMYqvEegtbQy/i8kximwzXQiK1nw4QF TF77C+MAPmLPBWcNmdEq9Q6+z1el34oN6iJXvxpLlaFhJkITsoA4hd6PAQmbcvQtAsCZiG4m6nz5Q 01RKYnYeXcPaI3FjTO2EexNqa5X/Y09r5E9+OGyfDW8M0mvoFIMT/XHPrZZ3ys7psTIyzrjNQR8a3 AwyAB1PQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lmHLg-005dw6-4v; Thu, 27 May 2021 14:51:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1076B300221; Thu, 27 May 2021 16:50:59 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E9AFA2018A4FC; Thu, 27 May 2021 16:50:58 +0200 (CEST) Date: Thu, 27 May 2021 16:50:58 +0200 From: Peter Zijlstra To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , kernel-team@android.com Subject: Re: [PATCH v7 16/22] sched: Defer wakeup in ttwu() for unschedulable frozen tasks Message-ID: References: <20210525151432.16875-1-will@kernel.org> <20210525151432.16875-17-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 04:31:51PM +0200, Peter Zijlstra wrote: > @@ -149,7 +144,7 @@ void __thaw_task(struct task_struct *p) > > spin_lock_irqsave(&freezer_lock, flags); > if (frozen(p)) > - wake_up_process(p); > + wake_up_state(p, TASK_FROZEN); Possibly, that wants | TASK_NORMAL added. > spin_unlock_irqrestore(&freezer_lock, flags); > }