From: Peter Zijlstra <peterz@infradead.org>
To: Haocheng Xie <xiehaocheng.cn@gmail.com>
Cc: mingo@kernel.org, acme@kernel.org,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/3] perf core: Make local function perf_pmu_snapshot_aux() static
Date: Wed, 26 May 2021 14:04:29 +0200 [thread overview]
Message-ID: <YK45TSGv+DeuR8+X@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210526115220.19134-2-xiehaocheng.cn@gmail.com>
On Wed, May 26, 2021 at 07:52:18PM +0800, Haocheng Xie wrote:
> Fixes the following W=1 kernel build warning:
> kernel/events/core.c:6670:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
>
> Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
> ---
> kernel/events/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6fee4a7..0d98d6a 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6667,7 +6667,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
> return data->aux_size;
> }
>
> -long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> +static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> struct perf_event *event,
> struct perf_output_handle *handle,
> unsigned long size)
Your $subject is broken (superfluous whitespace) and you've wrecked
alignment of the arguments in the core.
next prev parent reply other threads:[~2021-05-26 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 11:52 [PATCH 0/3] Fix some build warnings in perf/events subsystem Haocheng Xie
2021-05-26 11:52 ` [PATCH 1/3] perf core: Make local function perf_pmu_snapshot_aux() static Haocheng Xie
2021-05-26 12:04 ` Peter Zijlstra [this message]
2021-05-27 3:50 ` Haocheng Xie
2021-05-26 11:52 ` [PATCH 2/3] perf core: Fix some kernel-doc warnings Haocheng Xie
2021-05-26 11:52 ` [PATCH 3/3] perf/hw_breakpoint: Fix kernel-doc warnings in perf hw_breakpoint Haocheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK45TSGv+DeuR8+X@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=xiehaocheng.cn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®