From: Peter Zijlstra <peterz@infradead.org>
To: Marco Elver <elver@google.com>
Cc: linux-kernel@vger.kernel.org, nathan@kernel.org,
ndesaulniers@google.com, ojeda@kernel.org, keescook@chromium.org,
akpm@linux-foundation.org, will@kernel.org, ardb@kernel.org,
luc.vanoostenryck@gmail.com, nivedita@alum.mit.edu,
masahiroy@kernel.org, samitolvanen@google.com, arnd@arndb.de,
clang-built-linux@googlegroups.com,
Dmitry Vyukov <dvyukov@google.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] kcov: add __no_sanitize_coverage to fix noinstr for all architectures
Date: Wed, 26 May 2021 10:19:04 +0200 [thread overview]
Message-ID: <YK4EeMhKUWQ9E92H@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210525175819.699786-1-elver@google.com>
On Tue, May 25, 2021 at 07:58:19PM +0200, Marco Elver wrote:
> Until now no compiler supported an attribute to disable coverage
> instrumentation as used by KCOV.
>
> To work around this limitation on x86, noinstr functions have their
> coverage instrumentation turned into nops by objtool. However, this
> solution doesn't scale automatically to other architectures, such as
> arm64, which are migrating to use the generic entry code.
>
> Clang [1] and GCC [2] have added support for the attribute recently.
> [1] https://github.com/llvm/llvm-project/commit/280333021e9550d80f5c1152a34e33e81df1e178
> [2] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cec4d4a6782c9bd8d071839c50a239c49caca689
>
> Add __no_sanitize_coverage for both compilers, and add it to noinstr.
>
> Signed-off-by: Marco Elver <elver@google.com>
W00t! Thanks guys!
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2021-05-26 8:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 17:58 Marco Elver
2021-05-25 18:25 ` Miguel Ojeda
2021-05-25 19:12 ` Marco Elver
2021-05-26 1:53 ` Miguel Ojeda
2021-05-26 6:25 ` Marco Elver
2021-05-26 12:38 ` Marco Elver
2021-05-26 18:12 ` Miguel Ojeda
2021-05-25 22:22 ` kernel test robot
2021-05-25 22:29 ` Marco Elver
2021-05-26 8:11 ` [kbuild-all] " Rong Chen
2021-05-25 23:21 ` kernel test robot
2021-05-26 8:19 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK4EeMhKUWQ9E92H@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=ojeda@kernel.org \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®