From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
Barry Song <song.bao.hua@hisilicon.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Input: cyttsp - do not force interrupt trigger
Date: Wed, 26 May 2021 17:05:15 -0700 [thread overview]
Message-ID: <YK7iO96g+7yIC0l1@google.com> (raw)
Instead of forcing interrupt trigger to be "falling edge" let's rely on the
platform to set it up according to how it is set up on a given board based
on data in device tree or ACPI tables.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Linus, Ferruh's email has been bouncing for ages, it looks like you have
the hardware and you are already looking over another Cypress touch
controller, mind if I put you down as a maintainer for this one as well?
drivers/input/touchscreen/cyttsp_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index d9debcdeeec7..a6352d79e23d 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -699,8 +699,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
}
error = devm_request_threaded_irq(dev, ts->irq, NULL, cyttsp_irq,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
- IRQF_NO_AUTOEN,
+ IRQF_ONESHOT | IRQF_NO_AUTOEN,
"cyttsp", ts);
if (error) {
dev_err(ts->dev, "failed to request IRQ %d, err: %d\n",
--
2.31.1.818.g46aad6cb9e-goog
--
Dmitry
next reply other threads:[~2021-05-27 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 0:05 Dmitry Torokhov [this message]
2021-05-27 0:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK7iO96g+7yIC0l1@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andrzej.p@collabora.com \
--cc=javier@dowhile0.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®