From: Christoph Hellwig <hch@infradead.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Avihai Horon <avihaih@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v1 1/2] RDMA: Enable Relaxed Ordering by default for kernel ULPs
Date: Thu, 27 May 2021 11:28:00 +0100 [thread overview]
Message-ID: <YK90MOp0ZKeUMf5w@infradead.org> (raw)
In-Reply-To: <73af770234656d5f884ead5b8d40132d9ed289d6.1621505111.git.leonro@nvidia.com>
The way this is implemented looks confusing and error prone to me.
I'd like to suggest the following:
1) add a prep patch that entirely untangles IB_ACCESS_* from
IB_UVERBS_ACCESS. Maybe even add a __bitwise type for IB_ACCESS_*
to allow sparse based type checking. Preferably ib_check_mr_access
could be changed into a function that does this translation as it
needs to be called anyway.
2) then just invert IB_ACCESS_RELAXED_ORDERING while keeping
IB_UVERBS_ACCESS_REMOTE_ATOMIC as-is, and enable
IB_ACCESS_STRICT_ORDERING if IB_UVERBS_ACCESS_REMOTE_ATOMIC is not
set in ib_check_mr_access.
next prev parent reply other threads:[~2021-05-27 10:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 10:13 [PATCH rdma-next v1 0/2] Enable relaxed ordering for ULPs Leon Romanovsky
2021-05-20 10:13 ` [PATCH rdma-next v1 1/2] RDMA: Enable Relaxed Ordering by default for kernel ULPs Leon Romanovsky
2021-05-27 10:28 ` Christoph Hellwig [this message]
2021-05-28 18:27 ` Jason Gunthorpe
2021-05-20 10:13 ` [PATCH rdma-next v1 2/2] RDMA/mlx5: Allow modifying Relaxed Ordering via fast registration Leon Romanovsky
2021-05-26 19:49 ` Jason Gunthorpe
2021-05-27 11:09 ` Christoph Hellwig
2021-05-27 14:57 ` Jason Gunthorpe
2021-05-27 15:06 ` Christoph Hellwig
2021-06-02 12:16 ` Leon Romanovsky
2021-05-26 19:30 ` [PATCH rdma-next v1 0/2] Enable relaxed ordering for ULPs Jason Gunthorpe
2021-05-27 8:11 ` David Laight
2021-05-31 18:13 ` Jason Gunthorpe
2021-05-31 21:45 ` David Laight
2021-05-31 22:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK90MOp0ZKeUMf5w@infradead.org \
--to=hch@infradead.org \
--cc=avihaih@nvidia.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®