From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449ACC47089 for ; Thu, 27 May 2021 11:01:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 220E8613C3 for ; Thu, 27 May 2021 11:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236314AbhE0LDK (ORCPT ); Thu, 27 May 2021 07:03:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:40794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236286AbhE0LDF (ORCPT ); Thu, 27 May 2021 07:03:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ECFDC60241; Thu, 27 May 2021 11:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622113291; bh=w82Buwz/8VJBRCQ6+DiA09zJU8SzJBV2/yXUWLoIPNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PNo5sgQh8W4nwNmlyMXlmg3EVLOOeUMmjYjTnWGTA78pT7GO3cQOr9FMehZHN7Grh A5mrNzTX6w9bYGiMev/+ojShZQYwVISxD46AhkoG94sFRSLepZWQ5RhTj1mSUMRD+z 4kNopQpYgv9nK7xvvZrW4xAJsDodnb6PKQvr8hxA= Date: Thu, 27 May 2021 13:01:28 +0200 From: Greg KH To: Bixuan Cui Cc: dan.carpenter@oracle.com, desmondcheongzx@gmail.com, marcocesati@gmail.com, fabioaiuto83@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] staging: rtl8723bs: HalBtc8723b1Ant.c: Remove unused variables Message-ID: References: <20210526074537.46259-1-cuibixuan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210526074537.46259-1-cuibixuan@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 26, 2021 at 03:45:37PM +0800, Bixuan Cui wrote: > Fix the build warning: [-Wunused-but-set-variable] > > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2710:6: warning: variable ‘u4Tmp’ set but not used > 2710 | u32 u4Tmp; > | ^~~~~ > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2709:13: warning: variable ‘u1Tmpb’ set but not used > 2709 | u8 u1Tmpa, u1Tmpb; > | ^~~~~~ > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2709:5: warning: variable ‘u1Tmpa’ set but not used > 2709 | u8 u1Tmpa, u1Tmpb; > | ^~~~~~ > > Reported-by: Hulk Robot > Signed-off-by: Bixuan Cui > --- > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c > index 518d5354bda4..adfdc4f14b08 100644 > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c > @@ -2706,9 +2706,6 @@ void EXhalbtc8723b1ant_ScanNotify(struct btc_coexist *pBtCoexist, u8 type) > bool bBtCtrlAggBufSize = false; > u8 aggBufSize = 5; > > - u8 u1Tmpa, u1Tmpb; > - u32 u4Tmp; > - > if (pBtCoexist->bManualControl || pBtCoexist->bStopCoexDm) > return; > > @@ -2716,9 +2713,9 @@ void EXhalbtc8723b1ant_ScanNotify(struct btc_coexist *pBtCoexist, u8 type) > pCoexSta->bWiFiIsHighPriTask = true; > > halbtc8723b1ant_PsTdma(pBtCoexist, FORCE_EXEC, false, 8); /* Force antenna setup for no scan result issue */ > - u4Tmp = pBtCoexist->fBtcRead4Byte(pBtCoexist, 0x948); > - u1Tmpa = pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x765); > - u1Tmpb = pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x67); > + pBtCoexist->fBtcRead4Byte(pBtCoexist, 0x948); > + pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x765); > + pBtCoexist->fBtcRead1Byte(pBtCoexist, 0x67); > } else { > pCoexSta->bWiFiIsHighPriTask = false; > > -- > 2.17.1 > > Does not apply to my tree :(