From: Matthew Wilcox <willy@infradead.org>
To: songqiang <songqiang@uniontech.com>
Cc: sam@ravnborg.org, b.zolnierkie@samsung.com,
penguin-kernel@i-love.sakura.ne.jp, george.kennedy@oracle.com,
arnd@arndb.de, tzimmermann@suse.de, jgg@ziepe.ca,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment
Date: Wed, 19 May 2021 13:16:54 +0100 [thread overview]
Message-ID: <YKUBtiOTE7zJHAjI@casper.infradead.org> (raw)
In-Reply-To: <20210519120028.7350-1-songqiang@uniontech.com>
On Wed, May 19, 2021 at 08:00:28PM +0800, songqiang wrote:
> Signed-off-by: songqiang <songqiang@uniontech.com>
> ---
You need to explain:
- Why you think this patch is needed
- Did you observe a problem at runtime?
- Is this the output from some checking tool?
- Why this is the right way to address the problem
next prev parent reply other threads:[~2021-05-19 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 12:00 songqiang
2021-05-19 12:16 ` Matthew Wilcox [this message]
[not found] ` <1049640176.41531.1621490295842.JavaMail.xmail@localhost.localdomain>
2021-05-20 7:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUBtiOTE7zJHAjI@casper.infradead.org \
--to=willy@infradead.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sam@ravnborg.org \
--cc=songqiang@uniontech.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®