From: Michal Hocko <mhocko@suse.com>
To: chenguanyou <chenguanyou9338@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
keescook@chromium.org, lukas.bulwahn@gmail.com, vbabka@suse.cz,
gpiccoli@canonical.com, chenguanyou <chenguanyou@xiaomi.com>
Subject: Re: [PATCH] hungtask: add filter kthread/check comm
Date: Wed, 19 May 2021 15:06:18 +0200 [thread overview]
Message-ID: <YKUNSkG5saX2QXhf@dhcp22.suse.cz> (raw)
In-Reply-To: <20210519121325.22083-1-chenguanyou@xiaomi.com>
On Wed 19-05-21 20:13:25, chenguanyou wrote:
> Some kernel threads are always in D state, when we enable hung_task,
> it will misjudge, we should skip these to narrow the scope.
Why they are in the D state in the first place?
Also you are proposing a new user interface which would need to be
maintained for ever. This means that any such a proposal has to be very
carefully justified. Always make sure to cc linux-api mailing list in
these cases.
From the (not much) information you have provided this interface seems
more like a workaround for buggy code so far.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-05-19 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 12:13 chenguanyou
2021-05-19 13:06 ` Michal Hocko [this message]
2021-05-19 17:53 ` Randy Dunlap
[not found] ` <CAHS3RMVYbHTzD6JnOmE331qSbcnvuYnBe0jraNuuLc0Z2NnStg@mail.gmail.com>
2021-05-21 8:31 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2021-05-21 13:25 chenguanyou
2021-05-22 21:51 ` Andrew Morton
[not found] ` <CAHS3RMWjuB98TzvcYyQ0qtNYOxDeM7W1YmyqDYs=H-cn-VsVdw@mail.gmail.com>
2021-05-25 7:26 ` Michal Hocko
2021-05-21 13:25 chenguanyou
2021-05-21 16:37 ` Randy Dunlap
2021-05-18 11:16 chenguanyou
2021-05-19 11:28 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUNSkG5saX2QXhf@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=chenguanyou9338@gmail.com \
--cc=chenguanyou@xiaomi.com \
--cc=gpiccoli@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®