From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEFBC433ED for ; Fri, 21 May 2021 11:48:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7ABE3613AE for ; Fri, 21 May 2021 11:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233238AbhEULuM (ORCPT ); Fri, 21 May 2021 07:50:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:39160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230401AbhEULuJ (ORCPT ); Fri, 21 May 2021 07:50:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 130DA613DA; Fri, 21 May 2021 11:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621597726; bh=rZqEZdVP5/Wm2Pn6E7g9wKzT5pGoLkymKZHnn3QSHBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wh4KPO9dpgmr2/v6HAn5EjeaDuvfkcKVwgkiexP9Z65pwj4oz7tJtVp0ycZ83THHq terpU4AqnegFczLG9GUrqoqi0T40psYmEBMBN6TjwYhGZqM6gIrIo6G0Ca2/4ysECl d6zn6AnQ+TYJ/d6o5mZJeyML+9RnryNAMtAJo83w= Date: Fri, 21 May 2021 13:48:44 +0200 From: Greg KH To: YueHaibing Cc: balbi@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] USB: gadget: f_fs: Use ERR_CAST instead of ERR_PTR(PTR_ERR(...)) Message-ID: References: <20210519023032.19812-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519023032.19812-1-yuehaibing@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 10:30:32AM +0800, YueHaibing wrote: > A coccicheck run provided information like the following. > > ./drivers/usb/gadget/function/f_fs.c:3832:9-16: > WARNING: ERR_CAST can be used with data > > Use ERR_CAST to fix this. > > Signed-off-by: YueHaibing > --- > drivers/usb/gadget/function/f_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index bf109191659a..61110ff52f49 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -3829,7 +3829,7 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len) > > data = memdup_user(buf, len); > if (IS_ERR(data)) > - return ERR_PTR(PTR_ERR(data)); > + return ERR_CAST(data); This should just be: return PTR_ERR(data); right? No need for 2 casts to happen here. thanks, greg k-h