From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9C4C47081 for ; Sun, 23 May 2021 14:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC90E61155 for ; Sun, 23 May 2021 14:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231827AbhEWOrp (ORCPT ); Sun, 23 May 2021 10:47:45 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53270 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbhEWOrn (ORCPT ); Sun, 23 May 2021 10:47:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Ect182xosKMp40my+SbKIak0EebPY4jC7+FdnqtirHU=; b=JTvNm6CARYHsNy8bPBRw0dBI36 ue13IgvEkns2qiBROEn0Qhwxk/FtPqLyJP+r7ExHOP2bDTMStd7PobEs+8Uk8sZVuVkHHwMBPbh+D b1wGZuy3GPTq6EU8mdl43SownMjNrCGQ6zMGip7AY0Oz9cv11nx/+VTrlx5Z2RK8y8M8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lkpMq-005nDd-Mv; Sun, 23 May 2021 16:46:12 +0200 Date: Sun, 23 May 2021 16:46:12 +0200 From: Andrew Lunn To: Joakim Zhang Cc: davem@davemloft.net, kuba@kernel.org, frieder.schrempf@kontron.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations Message-ID: References: <20210523102019.29440-1-qiangqing.zhang@nxp.com> <20210523102019.29440-3-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210523102019.29440-3-qiangqing.zhang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 23, 2021 at 06:20:19PM +0800, Joakim Zhang wrote: > From: Fugang Duan > > As we know that AVB is enabled by default, and the ENET IP design is > queue 0 for best effort, queue 1&2 for AVB Class A&B. Bandwidth of > queue 1&2 set in driver is 50%, TX bandwidth fluctuated when selecting > tx queues randomly with FEC_QUIRK_HAS_AVB quirk available. How is the driver currently scheduling between these queues? Given the 802.1q priorities, i think we want queue 2 with the highest priority for scheduling. Then queue 0 and lastly queue 1. Andrew