From: Lubomir Rintel <lkundrak@v3.sk>
To: nizamhaider786@gmail.com
Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed redundant fops assignment, which was already done in cdev_init()
Date: Mon, 24 May 2021 09:10:02 +0200 [thread overview]
Message-ID: <YKtRSiVK1QEJasP+@demiurge.local> (raw)
In-Reply-To: <20210523151111.2968-2-nizamhaider786@gmail.com>
On Sun, May 23, 2021 at 08:41:11PM +0530, nizamhaider786@gmail.com wrote:
> From: Nijam Haider <nizamhaider786@gmail.com>
>
Thank you for this. Needs another spin though:
> Subject: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed
^
It seems like you accidentally removed a line break here ---------|,
squishing the subject and patch description together.
> redundant fops assignment, which was already done in cdev_init()
Regards,
Lubo
> Signed-off-by: Nijam Haider <nizamhaider786@gmail.com>
> ---
> drivers/char/pcmcia/scr24x_cs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
> index cad1990..0265d72 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -266,7 +266,6 @@ static int scr24x_probe(struct pcmcia_device *link)
>
> cdev_init(&dev->c_dev, &scr24x_fops);
> dev->c_dev.owner = THIS_MODULE;
> - dev->c_dev.ops = &scr24x_fops;
> ret = cdev_add(&dev->c_dev, MKDEV(MAJOR(scr24x_devt), dev->devno), 1);
> if (ret < 0)
> goto err;
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-05-24 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 15:11 [PATCH 1/2] char: pcmcia: scr24x_cs: Fix failure handling Handled failure cases of pcmcia_enable_device() and device_create() nizamhaider786
2021-05-23 15:11 ` [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed redundant fops assignment, which was already done in cdev_init() nizamhaider786
2021-05-24 7:05 ` Greg KH
2021-05-24 7:10 ` Lubomir Rintel [this message]
2021-05-24 7:04 ` [PATCH 1/2] char: pcmcia: scr24x_cs: Fix failure handling Handled failure cases of pcmcia_enable_device() and device_create() Greg KH
2021-05-24 7:14 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKtRSiVK1QEJasP+@demiurge.local \
--to=lkundrak@v3.sk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nizamhaider786@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®