From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3135EC47088 for ; Tue, 25 May 2021 06:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1552B613F9 for ; Tue, 25 May 2021 06:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbhEYG3l (ORCPT ); Tue, 25 May 2021 02:29:41 -0400 Received: from muru.com ([72.249.23.125]:60060 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbhEYG3c (ORCPT ); Tue, 25 May 2021 02:29:32 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BF01D807E; Tue, 25 May 2021 06:28:06 +0000 (UTC) Date: Tue, 25 May 2021 09:27:58 +0300 From: Tony Lindgren To: Suman Anna Cc: Gowtham Tammana , bcousson@baylibre.com, robh+dt@kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grygorii Strashko , Nisanth Menon Subject: Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device node Message-ID: References: <20210521211851.14674-1-g-tammana@ti.com> <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Suman Anna [210524 15:24]: > This can be fixed in couple of different ways, and I see there have been > different commits that have ultimately caused this. > 6b14eb4705d6 ("ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi") > 549fce068a31 ("ARM: dts: dra7: Add l4 interconnect hierarchy and ti-sysc data" > bcbb63b80284 (ARM: dts: dra7: Separate AM57 dtsi files") > c7b72abca61e ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3") > > Would you prefer that we just drop the USB4 target-module reference in > dra7-l4.dtsi following the first commit? Looking at commit 549fce068a31 above, we have dra7-l4.dtsi define a module at 0x48940000. But maybe the module is only used for dwc on dra74x? If this controller instance is on all dra7 SoCs, then it should be in dra7-l4.dtsi. If the controller instance is only on dra74x, it should be only in dra74x.dtsi file. Sorry sounds like I have confused some hardware differences along the way. Regards, Tony