From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06A5C2B9F8 for ; Tue, 25 May 2021 07:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F0EA6138C for ; Tue, 25 May 2021 07:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231586AbhEYHN3 (ORCPT ); Tue, 25 May 2021 03:13:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbhEYHN0 (ORCPT ); Tue, 25 May 2021 03:13:26 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D78FC06138F for ; Tue, 25 May 2021 00:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IWoTzUWGEA8QI6T9mXA939T0pl7/ejFJCvJ7EsHPrj0=; b=FWhB9H23WSP1ofYSpC10VpATAI DWq/QqgH2hwFomnnFvRu2Tf3SiyVf/dBwLLGBSNxK+5nP0Iub2mzuWWpkrwzDmBPweDh3KpwMRxfw UwoI6a1zz++4tRxKZVMkDvTELwYNO0unUzsiMEnh0awpHlRaP7dTGIqZo7M6EGRpF1prsgp9LyE6s oGcC1EWgDVTkM6BHiXbK5RQPQ3tr2h683CAHPfDGuoOpf3hqOU86I34AP43BPyMWu5Y3tRqIqdi9B X3tDKyGOuWF7rB6aUrXy13jipHN/BEuFOfOaL4gZXHTsBXFWnXiZxMKWLIdVKkWM1EGonKgpJfhwq Ijy8YzTQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1llRDV-003Dfj-Qt; Tue, 25 May 2021 07:11:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A22653001E4; Tue, 25 May 2021 09:11:04 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8860931474563; Tue, 25 May 2021 09:11:04 +0200 (CEST) Date: Tue, 25 May 2021 09:11:04 +0200 From: Peter Zijlstra To: kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] kvm: fix boolreturn.cocci warnings Message-ID: References: <202105251316.O1igBtAa-lkp@intel.com> <20210525055940.GA7291@9b81fe870f96> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210525055940.GA7291@9b81fe870f96> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 01:59:40PM +0800, kernel test robot wrote: > From: kernel test robot > > arch/arm64/kvm/mmu.c:1203:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool > arch/arm64/kvm/mmu.c:1173:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool > arch/arm64/kvm/mmu.c:1216:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool > arch/arm64/kvm/mmu.c:1159:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci Per 2b076054e524 ("remove boolinit.cocci"), I have a very dim view of this sort of thing. > Fixes: 63b3f96e1a98 ("kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT") *how* ?!?