From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22964C48BCF for ; Tue, 8 Jun 2021 19:04:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 070CE613BC for ; Tue, 8 Jun 2021 19:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237168AbhFHTEV (ORCPT ); Tue, 8 Jun 2021 15:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237000AbhFHS4O (ORCPT ); Tue, 8 Jun 2021 14:56:14 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06570C061150 for ; Tue, 8 Jun 2021 11:51:35 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id x6so6486698qvx.4 for ; Tue, 08 Jun 2021 11:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BHtJ01+O9MGfngUx/tkkUwGswFNUD5Vr6xavfI/bB+w=; b=v3P4A1Ia9fsZuLq0N6xEVC9DWIR7E5XQuvfED1xa+4ijHr+R0m5duY4PKJQvebPG15 hRsCLgqHerQAPTwhfmwD7jTNb/ulH6gF+KGJ+w76AqRERi19GdhmSOj+dZ+2zYIxX57C uw4tKBJkwaiv6f2xuCQt+8NnVu5ChESNI3Z4Upi4KY8a6frhl+UguSbowW9snrC9grp6 lqG8bEjshk27OswFtIzW06u2agWPAgiLdpeKcMkkXteZHMGasVnfRVvEUt5AH4H23uMd LFi9PFcCnOjOrPCZOr5VVTCXC7q9GaoKD79JiY+vGKpDQIqEBAZDqHWTraY1bruDCPsV Uycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BHtJ01+O9MGfngUx/tkkUwGswFNUD5Vr6xavfI/bB+w=; b=QD3UPfM8q1tT7+tvFVe7Jig7ikyi15XefHp9Gb5ZcTZ2FgF7zY+upR1G2J1cw8EXW6 8U4HNJ2qrYXsrFP3OORAp9sHmppiB9i6GjczHyjniNudFdsBeU7TrEsFwePkN7babTgK lR5wCaLYVCgtlvXJPYVqTkeFaSUL8U0tVYDBbQIPL54ZPUlj4st0xOIHtLoXaJ+cpbSZ qe1THa6bmZYQ/b4wfDAlI4PS9M3ko7l/2YKiVkkWCMqtSzUhhpdfjqb9boezgNRHiBrX WSpSNOcS7FSsIxXINtozfPW+VWly/AGH0e12TI2N2VJB108s8LrQKPEAnWcVnlXPuAcJ mYow== X-Gm-Message-State: AOAM5335TdupK/YG6CcaR/NBy0z+lanjlcCxuiIl4352rBHvZvK1x/24 M4rnGpYYZOvPS+5biFZe8j+RrQ== X-Google-Smtp-Source: ABdhPJxDcpfYFvT+QzXz+jWD0tUoHBqOV1mhqCUxmPjSaeqEDUlqv5gxjBz9Vy9KsoVyiITJCIQe1w== X-Received: by 2002:ad4:5fc7:: with SMTP id jq7mr1615457qvb.41.1623178294157; Tue, 08 Jun 2021 11:51:34 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id g2sm6107432qtb.63.2021.06.08.11.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 11:51:33 -0700 (PDT) Date: Tue, 8 Jun 2021 14:51:32 -0400 From: Johannes Weiner To: Suren Baghdasaryan Cc: Tejun Heo , Zefan Li , Ingo Molnar , Peter Zijlstra , Shakeel Butt , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Mel Gorman , Minchan Kim , Jonathan Corbet , Daniel Bristot de Oliveira , "Paul E . McKenney" , Randy Dunlap , Andrew Morton , Thomas Gleixner , macro@orcam.me.uk, Viresh Kumar , Mike Kravetz , linux-doc@vger.kernel.org, LKML , cgroups mailinglist , kernel-team Subject: Re: [PATCH v3 1/1] cgroup: make per-cgroup pressure stall tracking configurable Message-ID: References: <20210524195339.1233449-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 09:25:08AM -0700, Suren Baghdasaryan wrote: > On Tue, May 25, 2021 at 6:00 AM Johannes Weiner wrote: > > > > On Mon, May 24, 2021 at 12:53:39PM -0700, Suren Baghdasaryan wrote: > > > PSI accounts stalls for each cgroup separately and aggregates it at each > > > level of the hierarchy. This causes additional overhead with psi_avgs_work > > > being called for each cgroup in the hierarchy. psi_avgs_work has been > > > highly optimized, however on systems with large number of cgroups the > > > overhead becomes noticeable. > > > Systems which use PSI only at the system level could avoid this overhead > > > if PSI can be configured to skip per-cgroup stall accounting. > > > Add "cgroup_disable=pressure" kernel command-line option to allow > > > requesting system-wide only pressure stall accounting. When set, it > > > keeps system-wide accounting under /proc/pressure/ but skips accounting > > > for individual cgroups and does not expose PSI nodes in cgroup hierarchy. > > > > > > Signed-off-by: Suren Baghdasaryan > > > > Acked-by: Johannes Weiner > > Gentle ping for cgroup folks to please take a look at the cgroup interface part. Tejun, this is more in cgroups territory than it is psi/scheduler, and should go through the cgroup tree. Both the psi and the cgroup side look good to me, and we have Peter's ack from the scheduler too. Do you have concerns about the cgroup side? If not, would you mind picking this up for 5.14? Thanks