From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A837C47094 for ; Mon, 7 Jun 2021 15:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 461F961185 for ; Mon, 7 Jun 2021 15:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbhFGPay (ORCPT ); Mon, 7 Jun 2021 11:30:54 -0400 Received: from mga06.intel.com ([134.134.136.31]:28731 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbhFGPaw (ORCPT ); Mon, 7 Jun 2021 11:30:52 -0400 IronPort-SDR: aVLnPAQEJDo4pPotTfC3rNSBzYPizkSax6qLIKCSR5wvzzUvFz8C+PUFIVgYW887Rnyn+FwipR idfQaxa7QiCw== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="265797684" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="265797684" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 08:28:59 -0700 IronPort-SDR: ZDOqp0VjZthuNlcLEFoR5ZLErRZX+kH4LxmMs0P5Nwo/qN5pmNsybcB552J7RHrqtV+eLZXb1w 08vzIm1pFK5A== X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="476244310" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 08:28:57 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lqHBP-000Hpe-5q; Mon, 07 Jun 2021 18:28:55 +0300 Date: Mon, 7 Jun 2021 18:28:55 +0300 From: Andy Shevchenko To: Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Greg Kroah-Hartman , kernel test robot Subject: Re: [PATCH v1 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header Message-ID: References: <20210519085534.48732-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 12:26:25PM +0300, Heikki Krogerus wrote: > On Wed, May 19, 2021 at 11:55:34AM +0300, Andy Shevchenko wrote: > > As LKP noticed the Sparse is not happy about strict type handling: > > .../typec/tcpm/wcove.c:380:50: sparse: expected unsigned short [usertype] header > > .../typec/tcpm/wcove.c:380:50: sparse: got restricted __le16 const [usertype] header > > > > Fix this by switching to use pd_header_cnt_le() instead of pd_header_cnt() > > in the affected code. > > > > Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together") > > Reported-by: kernel test robot > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Heikki Krogerus Thanks! Greg, should I amend or resend this? -- With Best Regards, Andy Shevchenko