From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06D6C4743F for ; Tue, 8 Jun 2021 14:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8D3861363 for ; Tue, 8 Jun 2021 14:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233190AbhFHOHL (ORCPT ); Tue, 8 Jun 2021 10:07:11 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51784 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233176AbhFHOHI (ORCPT ); Tue, 8 Jun 2021 10:07:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=omHxetGSf7WvvYJIz4CtL+xJtQiHSODIemCHft0cr2A=; b=iE OybeMN7wY1+wMg1xRqw8c16xMPRhSuDIhcUcDTwMJdmkOASe08GQKjpV+1qKSiyUxhixe74HQ/NWH /sTZWkqQZ2IPJUnW/HdNOP3honl1nn/7H4XQOqNIsTpv1YEuLGaQhqdwtTxSWnoSfzZjh2sHqweVt Sgnkf6lyJ2kutWc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lqcLe-008Lsy-Lx; Tue, 08 Jun 2021 16:04:54 +0200 Date: Tue, 8 Jun 2021 16:04:54 +0200 From: Andrew Lunn To: Zhou Yanjie Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, sihui.liu@ingenic.com, jun.jiang@ingenic.com, sernia.zhou@foxmail.com, paul@crapouillou.net Subject: Re: [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support. Message-ID: References: <1623086867-119039-1-git-send-email-zhouyanjie@wanyeetech.com> <1623086867-119039-3-git-send-email-zhouyanjie@wanyeetech.com> <6532a195-65db-afb3-37a2-f68bfed9d908@wanyeetech.com> <62ad605f-3689-cab3-e43e-9b6954da8df3@wanyeetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <62ad605f-3689-cab3-e43e-9b6954da8df3@wanyeetech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 09:48:38PM +0800, Zhou Yanjie wrote: > Hello Andrew, > > On 2021/6/8 下午8:21, Andrew Lunn wrote: > > Please wrap your text to around 75 characters per line. > > > Sure. > > > > > > I suspect you don't understand RGMII delays. As i said, normally, the > > MAC does not add delays, the PHY does. Please take a closer look at > > this. > > > According to the description of ethernet-controller.yaml, "rgmii" seems > > to allow MAC to add TX delay (the description in ethernet-controller.yaml > > is "RX and TX delays are added by the MAC when required"), while rgmii-id > > and rgmii-txid do not allow MAC to add delay (the description in > > ethernet-controller.yaml is"RGMII with internal RX and TX delays provided > > by the PHY, the MAC should not add the RX or TX delays in this case" and > > "RGMII with internal TX delay provided by the PHY, the MAC should not add > > an TX delay in this case"), I will add support for the other three RGMII > modes > > in the next version (I forgot to reply to this in the previous email). Please follow the code all the way through. What gets passed to phylink_create() is very important. If you have both the MAC and the PHY adding delays, bad things will happen. Andrew