From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hailong Liu <liuhailongg6@163.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Vitor Massaru Iha <vitor@massaru.org>,
Sedat Dilek <sedat.dilek@gmail.com>,
Wei Yang <richard.weiyang@gmail.com>,
linux-kernel@vger.kernel.org,
Hailong Liu <liu.hailong6@zte.com.cn>
Subject: Re: [PATCH] sched/debug:fix stale comments of sched_debug
Date: Mon, 31 May 2021 19:05:22 +0300 [thread overview]
Message-ID: <YLUJQp4fdEAW4GzY@smile.fi.intel.com> (raw)
In-Reply-To: <48a36f92-e8cf-d62b-e4d5-bf6911bcbbcf@163.com>
On Mon, May 31, 2021 at 10:09:36PM +0800, Hailong Liu wrote:
> On 5/31/21 3:48 PM, Andy Shevchenko wrote:
> > On Sun, May 30, 2021 at 10:51:45AM +0800, Hailong Liu wrote:
> >> From: Hailong Liu <liu.hailong6@zte.com.cn>
> >>
> >> Now /proc/sched_debug has been moved to debugfs, so make the comments
> >> consistent with it.
> >
> > Have you checked if the very same Kconfig option is used for something
> > slightly different as well?
>
> Do you mean that I need to check whether SCHED_DEBUG is also related to
> other features?
Yes.
> >> Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
> >
> > Missed SoB tag of the submitter.
>
> In fact the exiting SoB tag of this patch is the actual submitter.
>
> I'm sorry that the inconsistency between the submission email and the SoB
> email address caused you to feel confused.
>
> For some personal reasons, I had to use an email at home and mark another
> email address as the submitter.
AFAIU the documentation you have to have two SoBs in this case.
> >> --- a/lib/Kconfig.debug
> >> +++ b/lib/Kconfig.debug
> >> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG
> >> depends on DEBUG_KERNEL && PROC_FS
> >
> > Are the dependencies correct?
>
> Based on your suggestion, I checked and it turned out that PROC_FS is not
> the correct dependency, but DEBUG_FS.
I guess you missed something.
> Shoud I change it to DEBUG_FS?
Please, double check.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-31 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 2:51 Hailong Liu
2021-05-31 7:48 ` Andy Shevchenko
2021-05-31 14:09 ` Hailong Liu
2021-05-31 15:48 ` Peter Zijlstra
2021-05-31 16:05 ` Andy Shevchenko [this message]
2021-06-01 7:56 ` Peter Zijlstra
2021-06-01 12:58 ` Andy Shevchenko
2021-06-01 14:16 ` Hailong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLUJQp4fdEAW4GzY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.hailong6@zte.com.cn \
--cc=liuhailongg6@163.com \
--cc=masahiroy@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®