From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Manikishan Ghantasala <manikishanghantasala@gmail.com>
Cc: Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h
Date: Wed, 2 Jun 2021 19:15:18 +0200 [thread overview]
Message-ID: <YLe8psfQLCb5bn2W@kroah.com> (raw)
In-Reply-To: <20210602160333.62163-1-manikishanghantasala@gmail.com>
On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
Why is this line here?
>
> "Macros with complex values should be enclosed in parentheses"
> by enclosing values in parantheses.
I can not understand this sentence, can you please reword it?
> Modified spacing around "|" and removed a space before tab.
This is not related to the first thing, please break this up into
multiple patches like the bot asked...
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-02 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 16:03 Manikishan Ghantasala
2021-06-02 17:15 ` Greg Kroah-Hartman [this message]
2021-06-02 17:34 ` Manikishan Ghantasala
2021-06-02 18:01 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2021-06-02 15:10 sh4nnu
2021-06-02 15:18 ` Greg Kroah-Hartman
2021-06-02 15:36 ` Joe Perches
2021-06-02 15:42 ` Manikishan Ghantasala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLe8psfQLCb5bn2W@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manikishanghantasala@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®