From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4726C4708F for ; Wed, 2 Jun 2021 18:01:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89FE06023D for ; Wed, 2 Jun 2021 18:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231435AbhFBSDZ (ORCPT ); Wed, 2 Jun 2021 14:03:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:49544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230231AbhFBSDY (ORCPT ); Wed, 2 Jun 2021 14:03:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F036560FF3; Wed, 2 Jun 2021 18:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622656901; bh=SKuMrIYNE1VEZvOpdodYaPRNRoFOigHauVhNGxi/FAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MkhCEoxk2oQcOG+JoOnIUKuAgxKTULnaYc6+Hu0x2hmH64I5gd0I46LpRqeV2KC1N 3tJaNBK8UJqQXlf+tzU2Zwb2bC50hoFXaeiU8fJ6I3hiOZfnijrgOv/a6VPrLjsByo E380m7DiGo2rkZiL1Q3pT24oY1d+Ym2h5l2LSABI= Date: Wed, 2 Jun 2021 20:01:38 +0200 From: Greg Kroah-Hartman To: Manikishan Ghantasala Cc: Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h Message-ID: References: <20210602160333.62163-1-manikishanghantasala@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 02, 2021 at 11:04:53PM +0530, Manikishan Ghantasala wrote: > On Wed, 2 Jun 2021 at 22:45, Greg Kroah-Hartman > wrote: > > > > On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote: > > > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue > > > > Why is this line here? > > > Added it as description and I put a break due to char limit. Is that what existing patches for this driver looks like? > > > > > > "Macros with complex values should be enclosed in parentheses" > > > by enclosing values in parantheses. > > > > I can not understand this sentence, can you please reword it? > > > I meant, I cleared(fixed) the error in quotes by enclosing them in parentheses. Please describe this better in the changelog text. > > > Modified spacing around "|" and removed a space before tab. > > > > This is not related to the first thing, please break this up into > > multiple patches like the bot asked... > > > Okay, will do. Do I have to make one for the 'space before tab' too? > or can I ignore it? One patch per logical type of change. thanks, greg k-h