mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: pjones@redhat.com, konrad@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ibft: Remove unneeded semicolon
Date: Wed, 2 Jun 2021 21:52:46 -0400	[thread overview]
Message-ID: <YLg17kKDiWEl7CF4@localhost.localdomain> (raw)
In-Reply-To: <20210601142132.4132319-1-zhengyongjun3@huawei.com>

On Tue, Jun 01, 2021 at 10:21:32PM +0800, Zheng Yongjun wrote:
> Remove unneeded semicolon.

Heya,

Please bear with me - but this semicolon does not seem to be hurting
anyone so not sure what bug this patch is trying to fix?

I would prefer to leave the code as is (with all its warts) unless
there are bugs or features to be added.

Thank you.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  drivers/firmware/iscsi_ibft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 7127a04bca19..d46da640f484 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -802,7 +802,7 @@ static void ibft_unregister(void)
>  		ibft_kobj = boot_kobj->data;
>  		if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
>  			sysfs_remove_link(&boot_kobj->kobj, "device");
> -	};
> +	}
>  }
>  
>  static void ibft_cleanup(void)
> -- 
> 2.25.1
> 

      reply	other threads:[~2021-06-03  1:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 14:21 Zheng Yongjun
2021-06-03  1:52 ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLg17kKDiWEl7CF4@localhost.localdomain \
    --to=konrad@darnok.org \
    --cc=konrad@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjones@redhat.com \
    --cc=zhengyongjun3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®