From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF829C47097 for ; Thu, 3 Jun 2021 11:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92B77613D8 for ; Thu, 3 Jun 2021 11:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbhFCLJn (ORCPT ); Thu, 3 Jun 2021 07:09:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhFCLJm (ORCPT ); Thu, 3 Jun 2021 07:09:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5DC09613D7; Thu, 3 Jun 2021 11:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622718477; bh=f4K5JWhbtxnt2GNMNdWE8aEyOnpUw3O1MWjxYMBbEFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K8TVXqawAQgHdbdZw+m67cZ6I5igyM+svwdaRgkzGO9Afs7/5Nkk1XHtm/0bFlMKY MqIZtIskyIpXA1wf8UAh/qBEjBKMYwJrF6Nsr9gIxsLtWP9B2AZLrcYKH81LBnDaRv /i+i0B3qIecGs46LUrju5XEFKv3Rjzjwf0PXQFeEc95WLWF8mO3mYY9rzVZrv3Ruhf AC/MuAJpOekC9FwDMn4CypOLosf8cmwmrNYzAKAWZe4Xjucdgn5aWCx0fZNWq+QYId 5X43Ew/txa80+VhzsSUb7M/oWzjRN8VQBzaEl/SoM/ygfRQrOd9Eow/O0rgYQHrQOj 9KdjkH3Jh07Tg== Date: Thu, 3 Jun 2021 16:37:53 +0530 From: Vinod Koul To: Zou Wei Cc: yoshihiro.shimoda.uh@renesas.com, geert+renesas@glider.be, wsa+renesas@sang-engineering.com, laurent.pinchart@ideasonboard.com, robin.murphy@arm.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Message-ID: References: <1622442963-54095-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622442963-54095-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31-05-21, 14:36, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Applied, thanks -- ~Vinod