From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D435C47096 for ; Fri, 4 Jun 2021 00:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4448F6140C for ; Fri, 4 Jun 2021 00:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbhFDAlj (ORCPT ); Thu, 3 Jun 2021 20:41:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFDAli (ORCPT ); Thu, 3 Jun 2021 20:41:38 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65FFC06174A for ; Thu, 3 Jun 2021 17:39:37 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id l23-20020a17090a0717b029016ae774f973so4253131pjl.1 for ; Thu, 03 Jun 2021 17:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hsyO5EEm3dG2GUVsZApwZQUFiUjt1oJTpcTgXFZNdfs=; b=BlYNVPE305FbxEUMO5lSCEn5LG3JutO1Lg3tWns9s0oCrpDQwG+i6qmuM/hisKYpP+ y5qZfeRJIC4++esHrRYMFwklEwa2AsIP8FI2G+izcydAmHDQpIvGWGtM265YiTqVep0S 1wPk4/uTSpfKNxeIwC0sNPU2Zfv4gAByw74Ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hsyO5EEm3dG2GUVsZApwZQUFiUjt1oJTpcTgXFZNdfs=; b=MWfsrfOvrCvfViz4YYqZMd32NfkGMR/m4U4XQqG5ef5S/Xx/rOKgns637oO0UwMKUn +3YTz+oSiAxywXl1BUuYYcGky68wyDGpDGI6iPaL/guTTjxeyyWD2uApqkX1vYXVH9ZP ByGTddMU/5MiVxrhc7oqngJCA2LajbBxUzr5+LJhSEBMnzdpWG+pf8CC6IhJ9IvpQcpo 4R8IeaiTnUAwOEGHMI3JqipJjj3nKXQdDQncp5a0/BDowNxwxngg/1m+yknLcWU9ypJH JCuNKNE51VohHBNrfnaXQRXyvhBf5Ni2HLOoXdCTG967ksEdDnU+j46XUpJK9YebLHE+ KRfw== X-Gm-Message-State: AOAM533yJOvob8Yq0+ns81Ex5ooqGwSBTOgf7l9o3gnCmSMVMHzCrIF9 21X9fWDI0/djd8+V5/YYxZwSLg== X-Google-Smtp-Source: ABdhPJwUR3L1tC9qXtsxtXxpLe8tNcJAE3/COLahbUTOQi2i1KnLOCdr6jBvw3P/Ytpi3HasD6ls1Q== X-Received: by 2002:a17:90a:7345:: with SMTP id j5mr13827315pjs.64.1622767177417; Thu, 03 Jun 2021 17:39:37 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:36b:f5b6:c380:9ccf]) by smtp.gmail.com with ESMTPSA id j16sm3074017pjn.55.2021.06.03.17.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 17:39:36 -0700 (PDT) Date: Fri, 4 Jun 2021 09:39:29 +0900 From: Sergey Senozhatsky To: Peter Zijlstra Cc: Sergey Senozhatsky , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Marc Zyngier , Huacai Chen , Paul Mackerras , Christian Borntraeger , Suleiman Souhlal , x86@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier Message-ID: References: <20210603164315.682994-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/06/03 19:27), Peter Zijlstra wrote: > On Fri, Jun 04, 2021 at 01:43:15AM +0900, Sergey Senozhatsky wrote: [..] > > > > +void kvm_arch_pm_notifier(struct kvm *kvm) > > +{ > > +} > > + > > long kvm_arch_vm_ioctl(struct file *filp, > > unsigned int ioctl, unsigned long arg) > > { > > What looks like you wants a __weak function. True. Thanks for the suggestion. I thought about it, but I recalled that tglx had __strong opinions on __weak functions.