From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 77681C47083
	for <linux-kernel@archiver.kernel.org>; Fri,  4 Jun 2021 05:10:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 50F2B6140F
	for <linux-kernel@archiver.kernel.org>; Fri,  4 Jun 2021 05:10:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229810AbhFDFMg (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 4 Jun 2021 01:12:36 -0400
Received: from mail.kernel.org ([198.145.29.99]:37338 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229490AbhFDFMg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Jun 2021 01:12:36 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 5417A61159;
        Fri,  4 Jun 2021 05:10:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1622783450;
        bh=V08DT/rxitsvVwLGSoYGINo0EcOHL6Poon3BXcOtnjQ=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=FV7Xjn8SnhrZCOzpZnDtaSyDVdycfol0f/WiqodERQIWWXJ/BzKmxxqP2SPYRCo++
         DPpQVb4mvCbcbMp8flLIhti2UFv0RcBgyVBpNzskb7dm5Ih2bZXWIztospS7+SH7Jh
         0GerI02wvG2kpEgTfXozO6YmyPaSg1yH5eULAicsmKHzxYfdds/Bpnv4w7mvQqKBw4
         V2SNBaN1TMIjjQJ3SwCWdUTjsQx9D311QiixXJj8eiU3Y6HKdUHhjaKJnCxiIGF/wF
         zHzuw/LwG9VkaEql+8bhhshDbx1fxWCXNwSTDqBF5E2ZJGUdk1B+ooQkbrCwzS6MRe
         vD+d+a6wHx5Xw==
Date:   Thu, 3 Jun 2021 22:10:48 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: clean up /sys/fs/f2fs/<disk>/features
Message-ID: <YLm12A7qKFyYYU0Z@sol.localdomain>
References: <20210603220834.1949988-1-jaegeuk@kernel.org>
 <YLmvIH/wVeKwSPCN@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YLmvIH/wVeKwSPCN@google.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 03, 2021 at 09:42:08PM -0700, Jaegeuk Kim wrote:
>  enum feat_id {
>  	FEAT_CRYPTO = 0,
>  	FEAT_BLKZONED,
> @@ -587,6 +601,7 @@ enum feat_id {
>  	FEAT_RO,
>  	FEAT_TEST_DUMMY_ENCRYPTION_V2,
>  	FEAT_ENCRYPTED_CASEFOLD,
> +	FEAT_PIN_FILE,
>  };
>  
>  static ssize_t f2fs_feature_show(struct f2fs_attr *a,
> @@ -610,6 +625,7 @@ static ssize_t f2fs_feature_show(struct f2fs_attr *a,
>  	case FEAT_RO:
>  	case FEAT_TEST_DUMMY_ENCRYPTION_V2:
>  	case FEAT_ENCRYPTED_CASEFOLD:
> +	case FEAT_PIN_FILE:
>  		return sprintf(buf, "supported\n");
>  	}
>  	return 0;

There's no need for the feat_id enum to exist.  If f2fs_feature_show() just
always printed "supported\n", it will do the right thing.

Also, adding pin_file probably should be a separate patch.  That seems to be a
bug fix, as pin_file was mistakenly added to the per-sb feature list instead of
to the kernel feature list?

> +static ssize_t f2fs_sb_feature_show(struct f2fs_attr *a,
> +		struct f2fs_sb_info *sbi, char *buf)
> +{
> +	if (F2FS_MATCH_FEATURE(sbi, a->id))
> +		return sprintf(buf, "supported\n");
> +	return sprintf(buf, "unsupported\n");
> +}

This can just use F2FS_HAS_FEATURE(), provided that encrypted_casefold isn't
included here, which it shouldn't be (as discussed elsewhere).

- Eric