From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20FE4C07E94 for ; Fri, 4 Jun 2021 08:40:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00DDA6140F for ; Fri, 4 Jun 2021 08:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbhFDIl6 (ORCPT ); Fri, 4 Jun 2021 04:41:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbhFDIl5 (ORCPT ); Fri, 4 Jun 2021 04:41:57 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 991BDC06174A for ; Fri, 4 Jun 2021 01:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qXJkxcEwIBu9Q5l9I0LHtYs/king+MVE7zIB/sgk2X0=; b=FpXeWg6E0jQdMhYGhJDCCbDvMf Qk9decS4JOfv/k1rEKDS7VRsIWYcTho4jnZPjKvB4zxmuHpl5sIDjF6jbSV99BOGFdwhoe1lR9e8x iKb5+ZXAqTkos/LZViN3XNoUnKc3UaBU5soZrVJOYtRVE89GjTLobE6nPrHuqviZ/xh5d5Sbwz0xx lPNFzQsBaIbzef1h+AGkoO8qBhjFdb8vWFflqXe9RrEH9gNLOlqUTqvub3qizadM/81IFlyx5wpYS JSWkr1xeH3r+22aE9+9i62hSa3S+2AuC/E1NDaQMsRi7YeAhpeqxqiY6ANYBjaGcnyBv5zjnOrJ5X TNgpy1ZA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lp5Mn-00CzXo-DL; Fri, 04 Jun 2021 08:39:48 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9EE0E300091; Fri, 4 Jun 2021 10:39:43 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 870DA2BE400DC; Fri, 4 Jun 2021 10:39:43 +0200 (CEST) Date: Fri, 4 Jun 2021 10:39:43 +0200 From: Peter Zijlstra To: Dietmar Eggemann Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Steven Rostedt , Greg Kroah-Hartman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH] debugfs: Fix debugfs_read_file_str() Message-ID: References: <20210527091105.258457-1-dietmar.eggemann@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527091105.258457-1-dietmar.eggemann@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 11:11:05AM +0200, Dietmar Eggemann wrote: > Read the entire size of the buffer, including the trailing new line > character. > Discovered while reading the sched domain names of CPU0: > > before: > > cat /sys/kernel/debug/sched/domains/cpu0/domain*/name > SMTMCDIE > > after: > > cat /sys/kernel/debug/sched/domains/cpu0/domain*/name > SMT > MC > DIE > > Fixes: 9af0440ec86eb ("debugfs: Implement debugfs_create_str()") > Signed-off-by: Dietmar Eggemann Urgh.. so much for last minute changes :/ Greg, AFAICT that commit has since landed in Linus, will you take care of this? Acked-by: Peter Zijlstra (Intel)