From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: jlayton@kernel.org, linux-afs@lists.infradead.org,
ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] afs: Fix afs_write_end() to handle short writes
Date: Mon, 14 Jun 2021 15:37:57 +0100 [thread overview]
Message-ID: <YMdpxbYafHnE0F8N@casper.infradead.org> (raw)
In-Reply-To: <162367682522.460125.5652091227576721609.stgit@warthog.procyon.org.uk>
On Mon, Jun 14, 2021 at 02:20:25PM +0100, David Howells wrote:
> @@ -135,8 +145,6 @@ int afs_write_end(struct file *file, struct address_space *mapping,
> write_sequnlock(&vnode->cb_lock);
> }
>
> - ASSERT(PageUptodate(page));
> -
> if (PagePrivate(page)) {
> priv = page_private(page);
> f = afs_page_dirty_from(page, priv);
Why are you removing this assertion? Does AFS now support dirty,
partially-uptodate pages? If so, a subsequent read() to that
page is going to need to be careful to only read the parts of the page
from the server that haven't been written ...
next prev parent reply other threads:[~2021-06-14 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 13:20 [PATCH 1/3] afs: Handle len being extending over page end in write_begin/write_end David Howells
2021-06-14 13:20 ` [PATCH 2/3] afs: Fix afs_write_end() to handle short writes David Howells
2021-06-14 13:28 ` Matthew Wilcox
2021-06-14 13:37 ` David Howells
2021-06-14 13:46 ` Matthew Wilcox
2021-06-18 3:40 ` Al Viro
2021-06-14 14:04 ` David Howells
2021-06-14 14:37 ` Matthew Wilcox [this message]
2021-06-14 15:38 ` David Howells
2021-06-14 15:43 ` Matthew Wilcox
2021-06-14 21:11 ` David Howells
2021-06-14 13:20 ` [PATCH 3/3] netfs: fix test for whether we can skip read when writing beyond EOF David Howells
2021-06-15 17:01 ` Jeff Layton
2021-06-14 13:33 ` David Howells
2021-06-17 7:43 ` [PATCH 1/3] afs: Handle len being extending over page end in write_begin/write_end kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMdpxbYafHnE0F8N@casper.infradead.org \
--to=willy@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®