From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ian Kent <raven@themaw.net>
Cc: Tejun Heo <tj@kernel.org>, Eric Sandeen <sandeen@sandeen.net>,
Fox Chen <foxhlchen@gmail.com>,
Brice Goglin <brice.goglin@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Rick Lindsley <ricklind@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Marcelo Tosatti <mtosatti@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Carlos Maiolino <cmaiolino@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] kernfs: move revalidate to be near lookup
Date: Tue, 15 Jun 2021 17:06:43 +0200 [thread overview]
Message-ID: <YMjCA6sgzOThbt6Z@kroah.com> (raw)
In-Reply-To: <162375275365.232295.8995526416263659926.stgit@web.messagingengine.com>
On Tue, Jun 15, 2021 at 06:25:53PM +0800, Ian Kent wrote:
> While the dentry operation kernfs_dop_revalidate() is grouped with
> dentry type functions it also has a strong affinity to the inode
> operation ->lookup().
>
> It makes sense to locate this function near to kernfs_iop_lookup()
> because we will be adding VFS negative dentry caching to reduce path
> lookup overhead for non-existent paths.
>
> There's no functional change from this patch.
>
> Signed-off-by: Ian Kent <raven@themaw.net>
> Reviewed-by: Miklos Szeredi <mszeredi@redhat.com>
> ---
> fs/kernfs/dir.c | 86 ++++++++++++++++++++++++++++---------------------------
> 1 file changed, 43 insertions(+), 43 deletions(-)
As everyone has agreed this patch does nothing wrong, I've applied this
one for now while everyone reviews the other ones :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-15 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:25 [PATCH v7 0/6] kernfs: proposed locking and concurrency improvement Ian Kent
2021-06-15 10:25 ` [PATCH v7 1/6] kernfs: move revalidate to be near lookup Ian Kent
2021-06-15 15:06 ` Greg Kroah-Hartman [this message]
2021-06-15 10:26 ` [PATCH v7 2/6] kernfs: add a revision to identify directory node changes Ian Kent
2021-06-16 9:11 ` Miklos Szeredi
2021-06-15 10:26 ` [PATCH v7 3/6] kernfs: use VFS negative dentry caching Ian Kent
2021-06-16 9:12 ` Miklos Szeredi
2021-06-15 10:26 ` [PATCH v7 4/6] kernfs: switch kernfs to use an rwsem Ian Kent
2021-06-15 10:26 ` [PATCH v7 5/6] kernfs: use i_lock to protect concurrent inode updates Ian Kent
2021-06-15 10:27 ` [PATCH v7 6/6] kernfs: dont call d_splice_alias() under kernfs node lock Ian Kent
2021-06-15 10:39 ` [PATCH v7 0/6] kernfs: proposed locking and concurrency improvement Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMjCA6sgzOThbt6Z@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brice.goglin@gmail.com \
--cc=cmaiolino@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=foxhlchen@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mtosatti@redhat.com \
--cc=raven@themaw.net \
--cc=ricklind@linux.vnet.ibm.com \
--cc=sandeen@sandeen.net \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®