From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49AEC49361 for ; Thu, 17 Jun 2021 12:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B86AE6135C for ; Thu, 17 Jun 2021 12:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhFQNBR (ORCPT ); Thu, 17 Jun 2021 09:01:17 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42580 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbhFQNBP (ORCPT ); Thu, 17 Jun 2021 09:01:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=hHXkwgKnNfp9L6OW35d26XLF9j9waBFBIWrHzICzUiA=; b=2jrxKMoVFqfxXdyWvZ5FM9OnW/ 7OssGebI5yQ27lLxmuqijnmLicIFZoQ/xbeDezh7OeDMum/zxlJlPDMFk53Z3+JBkxFWb74NmM46v QFNqnErKV4bez28i7VyL3LjN7I2lrMP7lRUyQ3yXjKKx9XLQYUduLHgdMiCHr4bZDW2s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ltrbt-009u8e-CN; Thu, 17 Jun 2021 14:59:05 +0200 Date: Thu, 17 Jun 2021 14:59:05 +0200 From: Andrew Lunn To: Marcin Wojtas Cc: Linux Kernel Mailing List , netdev , "David S. Miller" , Jakub Kicinski , Russell King - ARM Linux , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud , Jon Nettleton , Tomasz Nowicki , rjw@rjwysocki.net, lenb@kernel.org Subject: Re: [net-next: PATCH v2 2/7] net: mdiobus: Introduce fwnode_mdbiobus_register() Message-ID: References: <20210616190759.2832033-1-mw@semihalf.com> <20210616190759.2832033-3-mw@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Actually mvmdio driver is using this fallback for non-dt platforms > (e.g. Orion). Therefore I would prefer to keep the current behavior. A quick look at Orion5x, it is now a multi arch MACH. It selects ARCH_MULTI_V5. Which seems to imply ARCH_MULTIPLATFORM which selects USE_OF which selects OF. At least for ARM, i'm not sure you can realistically disable OF. Having said that acpi_mdiobus_register() also falls back to mdiobus_register(mdio). So it is symmetric. And fwmode_mdiobus_register() falling back would keep with the symmetry. So, O.K. Andrew