From: Peter Zijlstra <peterz@infradead.org>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>, Josh Don <joshdon@google.com>,
Juri Lelli <juri.lelli@redhat.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Mel Gorman <mgorman@suse.de>, Qais Yousef <qais.yousef@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
rostedt@goodmis.org
Subject: Re: [RFC] schedutil: Fix iowait boost issues for slow I/O devices
Date: Fri, 18 Jun 2021 10:34:09 +0200 [thread overview]
Message-ID: <YMxagWy/Ioj3aere@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210618040639.3113489-1-joel@joelfernandes.org>
Aside from everything else:
On Fri, Jun 18, 2021 at 12:06:39AM -0400, Joel Fernandes (Google) wrote:
> +unsigned int sysctl_iowait_reset_ticks = 20;
> +unsigned int sysctl_iowait_apply_ticks = 10;
Never expose HZ to userspace. we even have USER_HZ (no new usage please)
that fixed existing problems with that.
If you expose a knob, make it in sane time units and convert internally
to whatever you need. That said; less is more with knobs.
next prev parent reply other threads:[~2021-06-18 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 4:06 Joel Fernandes (Google)
2021-06-18 4:07 ` Joel Fernandes
2021-06-21 12:25 ` Beata Michalska
2021-06-18 8:34 ` Peter Zijlstra [this message]
2021-06-19 0:33 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMxagWy/Ioj3aere@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=qais.yousef@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®