From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 062EDC48BE8 for ; Fri, 18 Jun 2021 09:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA480613BA for ; Fri, 18 Jun 2021 09:20:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231968AbhFRJWN (ORCPT ); Fri, 18 Jun 2021 05:22:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:53262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbhFRJWM (ORCPT ); Fri, 18 Jun 2021 05:22:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C9B21613CB; Fri, 18 Jun 2021 09:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624008002; bh=cvH1HolDomQ1JrJb/PeQTtCMcu+iu/sWcsrXs8OyMpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=er2Y+qlQGrwxer27jkokoi+hN50oAJ+Hvh7n5tD4nzNqdtaNa8rSP8XeWIlMRMu1s q5clhxRsx5GIMl4jxksGCF4QTez5k3Ib3dnln7IFeNiX410fRjaXDoCHkGMOwzLuqd 2ARNz7b96oaNnsByZWs3lYuaoDr8ZTaiAYc8nmk0= Date: Fri, 18 Jun 2021 11:19:59 +0200 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel Vetter , Christoph Hellwig , Jessica Yu Subject: Re: [PATCH 5.4 031/184] modules: inherit TAINT_PROPRIETARY_MODULE Message-ID: References: <20210510101950.200777181@linuxfoundation.org> <20210510101951.249384110@linuxfoundation.org> <8edc6f45-6c42-19c7-6f40-6f1a49cc685b@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8edc6f45-6c42-19c7-6f40-6f1a49cc685b@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 10:57:23AM +0200, Krzysztof Kozlowski wrote: > On 10/05/2021 12:18, Greg Kroah-Hartman wrote: > > From: Christoph Hellwig > > > > commit 262e6ae7081df304fc625cf368d5c2cbba2bb991 upstream. > > > > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag > > for all modules importing these symbols, and don't allow loading > > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > > imported gplonly symbols. Add a anti-circumvention devices so people > > don't accidentally get themselves into trouble this way. > > > > Comment from Greg: > > "Ah, the proven-to-be-illegal "GPL Condom" defense :)" > > Patch got in to stable, so my comments are quite late, but can someone > explain me - how this is a stable material? What specific, real bug that > bothers people, is being fixed here? Or maybe it fixes serious issue > reported by a user of distribution kernel? IOW, how does this match > stable kernel rules at all? > > For sure it breaks some out-of-tree modules already present and used by > customers of downstream stable kernels. Therefore I wonder what is the > bug fixed here, so the breakage and annoyance of stable users is justified. It fixes a reported bug in that somehow symbols are being exported to modules that should not have been. This has been in mainline and newer stable releases for quite some time, it should not be a suprise that this was backported further as well. thanks, greg k-h