From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 813F9C49EA6 for ; Thu, 24 Jun 2021 12:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6059661374 for ; Thu, 24 Jun 2021 12:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231865AbhFXMyT (ORCPT ); Thu, 24 Jun 2021 08:54:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbhFXMyR (ORCPT ); Thu, 24 Jun 2021 08:54:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E93BEC061574; Thu, 24 Jun 2021 05:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JjqzPDjGNDhHumqGJMc0l3thrqr4HCxhcR5q9gXHRVI=; b=ZHXFAOScAfgMoquJF+eOmfyt/0 u4lfdzcsYHoMIAVufKj0U1kRaUkZlD0/SEeeGgG1WIgHqH3tfofg9Co8DWV7+R6be80c+s8WJNklt TjiY0fQ4/m0tD6E3RT7YWEk6izmllQH7H/mLczr89FTJTSV+99T8L2r0Q53JsILuQ2n8tkeSLqcsn upkNqijoUF0LNd3ZagzBydpkgR9mrJ4d9PzTqvDk+fAkx2CVZC1KorUA4MU+68xsz7s16smj9seis 1B0oOcb5FekbmeNawc/jlqVtIg4dGOZQRLSMX9KCguiao0RXE0J3sGc03+iP+UKwFNaNHBHcyJFzb mcoEUyEw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwOpH-00GaLw-B1; Thu, 24 Jun 2021 12:51:27 +0000 Date: Thu, 24 Jun 2021 13:51:23 +0100 From: Christoph Hellwig To: Gao Xiang Cc: linux-nfs@vger.kernel.org, LKML , Trond Myklebust , Anna Schumaker , Christoph Hellwig , Joseph Qi Subject: Re: [PATCH v2 1/2] nfs: fix acl memory leak of posix_acl_create() Message-ID: References: <1624430335-10322-1-git-send-email-hsiangkao@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624430335-10322-1-git-send-email-hsiangkao@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021 at 02:38:54PM +0800, Gao Xiang wrote: > When looking into another nfs xfstests report, I found acl and > default_acl in nfs3_proc_create() and nfs3_proc_mknod() error > paths are possibly leaked. Fix them in advance. Looks fine, Reviewed-by: Christoph Hellwig