From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB47C48BDF for ; Thu, 24 Jun 2021 09:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A294613EC for ; Thu, 24 Jun 2021 09:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231887AbhFXJbo (ORCPT ); Thu, 24 Jun 2021 05:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbhFXJbm (ORCPT ); Thu, 24 Jun 2021 05:31:42 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B995C061574 for ; Thu, 24 Jun 2021 02:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tyy6oGPDtSV9dFs168w/OuRhaDOFXHofllzuyVaRCEQ=; b=lVGtM5BxpvBqXHCJtXY8Lm+Lkc mTIbmW23XvbA4/r89s4H7FCCveAUi3c+08nxekHfnkYzsp8Ng2PRgtG8DXeXp9P75JAD4G7UZSAmT WLWqJUy0/nx3JwmgicgO9N6FrFy+4HLmN3Te7whg9CdgUEZ21etPOjHbIJQW5AMP3f9KVFNPiBG9Q DgNtIhQh8HW+yiUIi3ArUMZJurmVzYwXb8NTEt5rsEj/fenJ2uN9TwzOGDv9TPKfltvMNqYTqChZl gifSyfstIVDkAotlhSX+Uw3Rae7MP/yMxfwZmEuICSALAKPMFHLX4i1fWxHA10RL6Okgqq1yD94hB Bv2eb5iQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwLfD-00BBtc-P3; Thu, 24 Jun 2021 09:28:54 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6198630022B; Thu, 24 Jun 2021 11:28:48 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4094F200B392A; Thu, 24 Jun 2021 11:28:48 +0200 (CEST) Date: Thu, 24 Jun 2021 11:28:48 +0200 From: Peter Zijlstra To: changhuaixin Cc: luca.abeni@santannapisa.it, anderson@cs.unc.edu, baruah@wustl.edu, Benjamin Segall , Dietmar Eggemann , dtcccc@linux.alibaba.com, Juri Lelli , khlebnikov@yandex-team.ru, open list , Mel Gorman , Ingo Molnar , Odin Ugedal , Odin Ugedal , pauld@redhead.com, Paul Turner , Steven Rostedt , Shanpei Chen , Tejun Heo , tommaso.cucinotta@santannapisa.it, Vincent Guittot , xiyou.wangcong@gmail.com Subject: Re: [PATCH v6 1/3] sched/fair: Introduce the burstable CFS controller Message-ID: References: <20210621092800.23714-1-changhuaixin@linux.alibaba.com> <20210621092800.23714-2-changhuaixin@linux.alibaba.com> <653A9CDE-2786-4174-9335-75F16B8631C0@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <653A9CDE-2786-4174-9335-75F16B8631C0@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 04:48:54PM +0800, changhuaixin wrote: > Hi, apart from the document issues Odin has replied, is there anything to improve for the other two patches? I don't like the second patch much; but I've not had enough time to actually think about anything yet, so I can't really make recommendations :/ I'll try and get to it..