From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor
Date: Thu, 24 Jun 2021 16:34:06 +0300 [thread overview]
Message-ID: <YNSJzgJ5xu2j+U2p@pendragon.ideasonboard.com> (raw)
In-Reply-To: <m3wnqj4ct3.fsf@t19.piap.pl>
On Thu, Jun 24, 2021 at 03:22:48PM +0200, Krzysztof Hałasa wrote:
> Hi Greg,
>
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > +// SPDX-License-Identifier: GPL-2.0
>
> > Putting the above line on a file _IS_ a legal declaration that the file
> > is released under GPL-2.0. It's pretty simple :)
Greg, on a side note, the discussion originated from
https://lore.kernel.org/linux-media/m3r1gt5hzm.fsf@t19.piap.pl/. I'll
quote Krzysztof so the discussion doesn't get split across multiple
places:
> > To spend time reviewing this code, I want to know it will be mergeable,
> > and that requires a SoB line. That's a blocker I'm afraid.
>
> So how do you propose to solve the situation, in which my driver is
> rejected, but another persor takes it, makes changes (btw breaking it),
> and presents it as their own, and it's accepted? This is a paid work and
> I'm required to put in my employer's copyright over the code.
> I could have made this error once - but no more.
>
> The code will be mergeable, as I already wrote. Why would I bother
> otherwise? But I cannot let that history to repeat itself.
Your opinion on this would be valuable too.
> Do you think putting this line anywhere, in any file, does it?
> That would be crazy.
>
> How about a book, e.g. describing a patch submission process (but not
> a copy of kernel's Documentation). The same?
>
> Also - in all countries? Most of them?
>
> Come on.
>
> Then why would we need the Signed-off-by?
> From my perspective, the SPDX-License-Identifier is only meaningful when
> the file is actually a part of the kernel, or if, at least, it's been
> presented for merge, with Signed-off-by etc.
Quoting Documentation/process/submitting-patches.rst:
Sign your work - the Developer's Certificate of Origin
------------------------------------------------------
To improve tracking of who did what, especially with patches that can
percolate to their final resting place in the kernel through several
layers of maintainers, we've introduced a "sign-off" procedure on
patches that are being emailed around.
The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right to
pass it on as an open-source patch. The rules are pretty simple: if you
can certify the below:
Developer's Certificate of Origin 1.1
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
then you just add a line saying::
Signed-off-by: Random J Developer <random@developer.example.org>
The SoB line doesn't convey any license information, that's specified
separately and explicitly in each file (usually in the form of an SPDX
tag, which is just a machine-parsable, short-hand version of a full
license header in text form).
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-06-24 13:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 11:18 Krzysztof Hałasa
2021-06-22 11:57 ` Laurent Pinchart
2021-06-23 4:21 ` Krzysztof Hałasa
2021-06-23 4:31 ` Laurent Pinchart
2021-06-23 5:28 ` Krzysztof Hałasa
2021-06-23 13:17 ` Laurent Pinchart
2021-06-23 14:27 ` Kieran Bingham
2021-06-24 4:57 ` Krzysztof Hałasa
2021-06-24 12:10 ` Laurent Pinchart
2021-06-24 12:39 ` Greg KH
2021-06-24 13:22 ` Krzysztof Hałasa
2021-06-24 13:29 ` Greg KH
2021-06-24 14:17 ` Krzysztof Hałasa
2021-06-24 14:31 ` Greg KH
2021-06-24 13:34 ` Laurent Pinchart [this message]
2021-06-24 14:42 ` Greg KH
2021-06-25 6:03 ` Krzysztof Hałasa
2021-06-25 6:59 ` Greg KH
2021-06-24 11:10 ` Mauro Carvalho Chehab
2021-06-24 13:51 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNSJzgJ5xu2j+U2p@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=khalasa@piap.pl \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®