From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE560C49EA7 for ; Thu, 24 Jun 2021 14:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B904613DA for ; Thu, 24 Jun 2021 14:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232004AbhFXOpE (ORCPT ); Thu, 24 Jun 2021 10:45:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:43478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230249AbhFXOpD (ORCPT ); Thu, 24 Jun 2021 10:45:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D170F613DA; Thu, 24 Jun 2021 14:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624545763; bh=e/VUPLUcS2+QL65BRNKsSnJsvm8jYUsqlgrW97FJOOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rh1F0ZJBTk8EOCB6kQvWjJjTKEUVrzyuX728AuP3zfkXSr6cVBR+9in3mwZWiiCkt rx950JqVehyOtbV8X5GluqSrGaXz7qI7murY8QJYZB3rpZqaHkeXwGqd5s+xoCFGvW e3IhatNxyGv8p55m4w+HrpSRi9NmltuDHGKSGSMg= Date: Thu, 24 Jun 2021 16:42:41 +0200 From: Greg KH To: Laurent Pinchart Cc: Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Kieran Bingham , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor Message-ID: References: <42958029-5625-5f4d-a075-2f59a74e0fb5@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 04:34:06PM +0300, Laurent Pinchart wrote: > On Thu, Jun 24, 2021 at 03:22:48PM +0200, Krzysztof Hałasa wrote: > > Hi Greg, > > > > Greg KH writes: > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > Putting the above line on a file _IS_ a legal declaration that the file > > > is released under GPL-2.0. It's pretty simple :) > > Greg, on a side note, the discussion originated from > https://lore.kernel.org/linux-media/m3r1gt5hzm.fsf@t19.piap.pl/. I'll > quote Krzysztof so the discussion doesn't get split across multiple > places: > > > > To spend time reviewing this code, I want to know it will be mergeable, > > > and that requires a SoB line. That's a blocker I'm afraid. > > > > So how do you propose to solve the situation, in which my driver is > > rejected, but another persor takes it, makes changes (btw breaking it), > > and presents it as their own, and it's accepted? This is a paid work and > > I'm required to put in my employer's copyright over the code. > > I could have made this error once - but no more. > > > > The code will be mergeable, as I already wrote. Why would I bother > > otherwise? But I cannot let that history to repeat itself. > > Your opinion on this would be valuable too. I would not waste my time on code that does not have a signed-off-by on it, otherwise the developer is obviously saying they do not want to merge this as-is. And I think we all have plenty of code from developers that actually want to have their patches merged. thanks, greg k-h