From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B92C49EA7 for ; Thu, 24 Jun 2021 16:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1739613C7 for ; Thu, 24 Jun 2021 16:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbhFXQ35 (ORCPT ); Thu, 24 Jun 2021 12:29:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhFXQ3z (ORCPT ); Thu, 24 Jun 2021 12:29:55 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D78C061574 for ; Thu, 24 Jun 2021 09:27:36 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwSCD-00BrFR-3s; Thu, 24 Jun 2021 16:27:17 +0000 Date: Thu, 24 Jun 2021 16:27:17 +0000 From: Al Viro To: Robin Murphy Cc: Matthew Wilcox , Christoph Hellwig , Chen Huang , Mark Rutland , Andrew Morton , Stephen Rothwell , Randy Dunlap , Catalin Marinas , Will Deacon , Linux ARM , linux-mm , open list Subject: Re: [BUG] arm64: an infinite loop in generic_perform_write() Message-ID: References: <20210623132223.GA96264@C02TD0UTHF1T.local> <1c635945-fb25-8871-7b34-f475f75b2caf@huawei.com> <27fbb8c1-2a65-738f-6bec-13f450395ab7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27fbb8c1-2a65-738f-6bec-13f450395ab7@arm.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 02:22:27PM +0100, Robin Murphy wrote: > FWIW I think the only way to make the kernel behaviour any more robust here > would be to make the whole uaccess API more expressive, such that rather > than simply saying "I only got this far" it could actually differentiate > between stopping due to a fault which may be recoverable and worth retrying, > and one which definitely isn't. ... and propagate that "more expressive" information through what, 3 or 4 levels in the call chain? >From include/linux/uaccess.h: * If raw_copy_{to,from}_user(to, from, size) returns N, size - N bytes starting * at to must become equal to the bytes fetched from the corresponding area * starting at from. All data past to + size - N must be left unmodified. * * If copying succeeds, the return value must be 0. If some data cannot be * fetched, it is permitted to copy less than had been fetched; the only * hard requirement is that not storing anything at all (i.e. returning size) * should happen only when nothing could be copied. In other words, you don't * have to squeeze as much as possible - it is allowed, but not necessary. arm64 instances violate the aforementioned hard requirement. Please, fix it there; it's not hard. All you need is an exception handler in .Ltiny15 that would fall back to (short) byte-by-byte copy if the faulting address happened to be unaligned. Or just do one-byte copy, not that it had been considerably cheaper than a loop. Will be cheaper than propagating that extra information up the call chain, let alone paying for extra ->write_begin() and ->write_end() for single byte in generic_perform_write().