From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92167C49EA7 for ; Fri, 25 Jun 2021 14:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FDB36196C for ; Fri, 25 Jun 2021 14:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbhFYOnK (ORCPT ); Fri, 25 Jun 2021 10:43:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55916 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231521AbhFYOnC (ORCPT ); Fri, 25 Jun 2021 10:43:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=w4IQO6DFVyzsolvAWmphYfHy/rPQ4YAG/FamYX4clww=; b=aAf3o6P+jbEuvDCewlGhAv0jYi Zc2Sx7la0Q//AkKE293wyg0aHPhF9/9XBKoM9dwYLoMZggjZkrwhJmSejyann22FOYQMZcc+/arjS N2RR5RRYjrLbq0aTs5r+4flsIKxF7rNwDt7cJuR3TPQ1DTM62X1cZtrWif9Vf2BBpGT4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lwn0H-00B79E-MB; Fri, 25 Jun 2021 16:40:21 +0200 Date: Fri, 25 Jun 2021 16:40:21 +0200 From: Andrew Lunn To: Lukasz Majewski Cc: "David S . Miller" , Jakub Kicinski , Madalin Bucur , Nicolas Ferre , Joakim Zhang , Florian Fainelli , Vladimir Oltean , netdev@vger.kernel.org, Arnd Bergmann , Mark Einon , NXP Linux Team , linux-kernel@vger.kernel.org Subject: Re: [RFC 2/3] net: Provide switchdev driver for NXP's More Than IP L2 switch Message-ID: References: <20210622144111.19647-1-lukma@denx.de> <20210622144111.19647-3-lukma@denx.de> <20210623133704.334a84df@ktm> <20210624125304.36636a44@ktm> <20210624163542.5b6d87ee@ktm> <20210625115935.132922ff@ktm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625115935.132922ff@ktm> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I do believe that I can just extend the L2 switch driver (fec_mtip.c > file to be precise) to provide full blown L2 switch functionality > without touching the legacy FEC more than in this patch set. > > Would you consider applying this patch series then? What is most important is the ABI. If something is merged now, we need to ensure it does not block later refactoring to a clean new driver. The DT binding is considered ABI. So the DT binding needs to be like a traditional switchdev driver. Florian already pointed out, you can use a binding very similar to DSA. ti,cpsw-switch.yaml is another good example. So before considering merging your changes, i would like to see a usable binding. I also don't remember seeing support for STP. Without that, your network has broadcast storm problems when there are loops. So i would like to see the code needed to put ports into blocking, listening, learning, and forwarding states. Andrew