From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137F0C48BC2 for ; Fri, 25 Jun 2021 22:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2FC36194D for ; Fri, 25 Jun 2021 22:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbhFYWZ0 (ORCPT ); Fri, 25 Jun 2021 18:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbhFYWZY (ORCPT ); Fri, 25 Jun 2021 18:25:24 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BDA1C061574; Fri, 25 Jun 2021 15:23:03 -0700 (PDT) Received: from zn.tnic (p200300ec2f0dae0029e536978a2ce722.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:ae00:29e5:3697:8a2c:e722]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0D5DE1EC0595; Sat, 26 Jun 2021 00:23:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1624659782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+EONHP3FxD4di+ShTJpnxsP/RC0RC7lxCcSSvwzWleg=; b=XDbsYazIHmjnMgA3eyoGZqu/0xS08Ey48sCw1KZiBKmlSI5s/uqHtWMAUwaLSnq0H8ibeW w78zxDlsg3xQakcGUF7JmKlV9jVDGJzmyS6LmFoBTIEZ5NPwK7+sR6I2vtXfDvaO2XX4xf +52R+PXgRLTXdFdgJbUEVBugJmgNy0M= Date: Sat, 26 Jun 2021 00:22:52 +0200 From: Borislav Petkov To: Steve Rutherford Cc: Ashish Kalra , pbonzini@redhat.com, seanjc@google.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, brijesh.singh@amd.com Subject: Re: [PATCH v4 5/5] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature. Message-ID: References: <8c581834c77284d5b9465b3388f07fa100f9fc4e.1623421410.git.ashish.kalra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2021 at 02:02:32PM -0700, Steve Rutherford wrote: > Boris, do you have any thoughts on the kexec aspect of this change? I'm suspecting you're asking here the wrong guy - I think you mean Paolo. But if I were to give some thoughts on this, I'd first request that this patch be split because it is doing a bunch of things at once. Then, I have no clue what "kexec support for SEV Live Migration" is. So this whole use case would need a lot more detailed explanation of all the moving parts and the "why" and the "because" and so on... But I'm no virt guy so perhaps this all makes sense to virt folks. Oh, and there's silly stuff like +static int __init setup_efi_kvm_sev_migration(void) { ... return true; } returning a bool but that's minor. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette