From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6E4C2B9F4 for ; Mon, 28 Jun 2021 08:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C67D661A0F for ; Mon, 28 Jun 2021 08:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232401AbhF1I2C (ORCPT ); Mon, 28 Jun 2021 04:28:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbhF1I2B (ORCPT ); Mon, 28 Jun 2021 04:28:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D56C5C061574 for ; Mon, 28 Jun 2021 01:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bBOOAJZmb1MGQkBOhTr3Y7C4iASxBA5CQqatO8OKvkU=; b=IcEY+/vJyPW5mfpsonXxEzgnK2 ij2cjBwdvkFvDpKT0mwZmUi1tZbHxGz0K4oI6cmwke1DT62/JaCr7pB6BSOLJAX1D/tVjkOouDAOR azyo8Erh9WYzCWTBPA7tNyhFRwvALHIAwddq2XtH94udA/1OcPY+W6OwLOfPjAV86OITTrXfG/mfp f2mTpaPvkdIFLmqb5I1jwTQ0gHno895wsth7lUaQNgsIMXPfLVM14Fk/NNripoW65fF0QCMRHM7Ak D6jD95Cp7/u1V+FHmN+Zx7zV4G8Q4XH4sh4RM3FOip4LOEISeGUE+mMO3bv1GAObXLcgGJH/1pNc3 +zD31TVQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxmZL-002k7t-Ll; Mon, 28 Jun 2021 08:24:51 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 00C153001DC; Mon, 28 Jun 2021 10:24:39 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D71FF2028DBF2; Mon, 28 Jun 2021 10:24:38 +0200 (CEST) Date: Mon, 28 Jun 2021 10:24:38 +0200 From: Peter Zijlstra To: Michael Forney Cc: Josh Poimboeuf , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] objtool: Check for gelf_update_rel[a] failures Message-ID: References: <20210509000103.11008-1-mforney@mforney.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 12:52:07AM -0700, Michael Forney wrote: > On 2021-05-08, Michael Forney wrote: > > Otherwise, if these fail we end up with garbage data in the > > .rela.orc_unwind_ip section, leading to errors like > > > > ld: fs/squashfs/namei.o: bad reloc symbol index (0x7f16 >= 0x12) for > > offset 0x7f16d5c82cc8 in section `.orc_unwind_ip' > > > > Signed-off-by: Michael Forney > > Ping on these patches. Josh, I forever forget which libelf versions we're supposed to support, But these patches do look reasonable to me, wdyt?