From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA516C1B08C for ; Thu, 15 Jul 2021 07:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB56E61358 for ; Thu, 15 Jul 2021 07:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240304AbhGOHWG (ORCPT ); Thu, 15 Jul 2021 03:22:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231718AbhGOHWF (ORCPT ); Thu, 15 Jul 2021 03:22:05 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C24EC06175F; Thu, 15 Jul 2021 00:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nmWxpA1sCjqxwnvgA3+hGJUbUWfCQNUSURcBD/p+N14=; b=AVWv5ghoR5f4WSYT3U7YMorrvt wwe3fegYbQdGbhgWe03oz6C/36QL+6uH8BO0nTkOXsqdbkKX3z8E9zxcZ4tASoBzzukz22LugTva4 GJG+Ilb9qPr8ckbp9R81OuNYGLgeXjHCZjjQ4bddUWXZ5qILfHoAtf2z9FQSJFu8Hqn5hlcV1M7OM 7oa0+Pou/K/DnlNbLhEOfP6YSkd3u68K2Jjwox3S4llQkBtYgVXxeA+D8LOxDLGRpfwGexIJehfH6 wLtX4az4dWbeQr6lCXUXzfAIpgyNHGfnkumwmPVZyl/E5z49iZnTiZMz7LaJQnvU8KLhvjt8m3QBP kH8EzDaA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3vcB-0035gL-OX; Thu, 15 Jul 2021 07:17:10 +0000 Date: Thu, 15 Jul 2021 08:16:59 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] block: move disk announce work from register_disk() to a helper Message-ID: References: <20210715045531.420201-1-mcgrof@kernel.org> <20210715045531.420201-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 08:05:41AM +0100, Christoph Hellwig wrote: > On Wed, Jul 14, 2021 at 09:55:27PM -0700, Luis Chamberlain wrote: > > This moves quite a bit of code which does one thing into a helper. > > We currently do not check for errors but we may decide that might > > be desirable later. > > > > This also makes the code easier to read. > > > > This change has no functional changes. > > On it's own I don't really see the point of moving two function > calls and a comment into a separate helper, but I'll see where this > series goes.. Looking at the whole context I still can't see a good reason for this helper.