From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64759C07E95 for ; Tue, 13 Jul 2021 06:59:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4023C61284 for ; Tue, 13 Jul 2021 06:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233980AbhGMHC0 (ORCPT ); Tue, 13 Jul 2021 03:02:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:56954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232908AbhGMHCZ (ORCPT ); Tue, 13 Jul 2021 03:02:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9845061003; Tue, 13 Jul 2021 06:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626159575; bh=CPoAqfXqh8v6lEBrf+dIf4GacQFoWE+iH27rViLAOF8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dRhkhyxH47WeNXn9m4VC3AeFPtf885Orea1TK/PqLxrPYWnfjGY8YR9PtQEJ4ZbPO 2sWEi2/Gl8+l8J6ZiJLiSJRQSd9Ym6ReJYZhqQcXx5q66u6cq+YxeELKx+uMkLJKh6 q3tUoL6D4/2XcJ5y2mjZvCxv111X/ikyDp3GTo4k= Date: Tue, 13 Jul 2021 08:59:32 +0200 From: Greg KH To: pandith.n@intel.com Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, furong.zhou@intel.com, mgross@linux.intel.com, mallikarjunappa.sangannavar@intel.com, andriy.shevchenko@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com Subject: Re: [PATCH V5 1/1] misc: NOC Probe Counters Message-ID: References: <20210713065347.21554-1-pandith.n@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210713065347.21554-1-pandith.n@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 13, 2021 at 12:23:47PM +0530, pandith.n@intel.com wrote: > +#define NOC_MAGIC 'n' > +#define NOC_SETUP _IOW(NOC_MAGIC, 1, void*) > +#define NOC_PROBE_START _IOW(NOC_MAGIC, 2, void*) > +#define NOC_COUNTER_CAPTURE _IOW(NOC_MAGIC, 3, void*) This was obviously not reviewed by Mark, otherwise he would have noticed how wrong this was :( {sigh} greg k-h