From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 10539C07E99
	for <linux-kernel@archiver.kernel.org>; Mon,  5 Jul 2021 15:38:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id EF10E61103
	for <linux-kernel@archiver.kernel.org>; Mon,  5 Jul 2021 15:38:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232161AbhGEPlG (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 5 Jul 2021 11:41:06 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39214 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233304AbhGEPlC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jul 2021 11:41:02 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 811C4C0A54D7
        for <linux-kernel@vger.kernel.org>; Mon,  5 Jul 2021 08:35:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=JT89CnNztpCRm65snzgKJDmEIG8nalFqjLQsFNStPn4=; b=CQHtJctBB09VUQakzJ4Zed/6+6
        2S4fgUhvBLr8kRtshzINIoCaVYZ0YeSX9k72rdH+zeF5RjO5uVwJFpEIz9F2RnGXfUxS2vpcYJm2p
        2ApDsBi1IVviZ0u0Q1u9DpMB2IJDTztTne1FeYdrQf/RLWAPdrTVdqNAzR298QU6GtKioXRo+KMmd
        QCqQiE7AhpySbr2VQR9RKCfTjsEAv8x9Rqztjl6jZmWssJ8rXpLcDbzOtxLtzACgR5V6LdfmkRgjO
        KIZ1NZSEZt5wfW6DcpeifPq8Hj0wJrA/SQouWKiEYPF8vBGmFZ4y6eO6uGUUdLPBLOxfnQdr0kdL9
        txtEHolA==;
Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1m0Qag-00AMmO-JJ; Mon, 05 Jul 2021 15:33:10 +0000
Date:   Mon, 5 Jul 2021 16:32:58 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>,
        Mel Gorman <mgorman@suse.de>,
        Christoph Hellwig <hch@infradead.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        Hillf Danton <hdanton@sina.com>,
        Michal Hocko <mhocko@suse.com>,
        Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] mm/vmalloc: Use batched page requests in bulk-allocator
Message-ID: <YOMmKo1FMNz048zV@casper.infradead.org>
References: <20210705145547.41206-1-urezki@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210705145547.41206-1-urezki@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 05, 2021 at 04:55:47PM +0200, Uladzislau Rezki (Sony) wrote:
> +			if (gfpflags_allow_blocking(gfp))
> +				cond_resched();

How does one call vmalloc() with gfp flags that _don't_ allow blocking?
They have to allow a GFP_KERNEL allocation of the page tables.
So I think this should be an unconditional cond_resched().