From: Greg KH <gregkh@linuxfoundation.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: robh+dt@kernel.org, frowand.list@gmail.com, balbi@kernel.org,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
jackp@codeaurora.org, fntoth@gmail.com
Subject: Re: [PATCH v13 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements
Date: Fri, 9 Jul 2021 07:41:23 +0200 [thread overview]
Message-ID: <YOfhg9FK8y72A/mw@kroah.com> (raw)
In-Reply-To: <1625790474-8376-4-git-send-email-wcheng@codeaurora.org>
On Thu, Jul 08, 2021 at 05:27:51PM -0700, Wesley Cheng wrote:
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index dccdf13..dd985ba 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1023,6 +1023,7 @@ struct dwc3_scratchpad_array {
> * @rx_max_burst_prd: max periodic ESS receive burst size
> * @tx_thr_num_pkt_prd: periodic ESS transmit packet count
> * @tx_max_burst_prd: max periodic ESS transmit burst size
> + * @tx_fifo_resize_max_num: max number of fifos allocated during txfifo resize
> * @hsphy_interface: "utmi" or "ulpi"
> * @connected: true when we're connected to a host, false otherwise
> * @delayed_status: true when gadget driver asks for delayed status
> @@ -1079,6 +1080,11 @@ struct dwc3_scratchpad_array {
> * @dis_split_quirk: set to disable split boundary.
> * @imod_interval: set the interrupt moderation interval in 250ns
> * increments or 0 to disable.
> + * @max_cfg_eps: current max number of IN eps used across all USB configs.
> + * @last_fifo_depth: last fifo depth used to determine next fifo ram start
> + * address.
> + * @num_ep_resized: carries the current number endpoints which have had its tx
> + * fifo resized.
> */
> struct dwc3 {
> struct work_struct drd_work;
> @@ -1233,6 +1239,7 @@ struct dwc3 {
> u8 rx_max_burst_prd;
> u8 tx_thr_num_pkt_prd;
> u8 tx_max_burst_prd;
> + u8 tx_fifo_resize_max_num;
>
> const char *hsphy_interface;
>
> @@ -1246,6 +1253,7 @@ struct dwc3 {
> unsigned is_utmi_l1_suspend:1;
> unsigned is_fpga:1;
> unsigned pending_events:1;
> + unsigned do_fifo_resize:1;
> unsigned pullups_connected:1;
> unsigned setup_packet_pending:1;
> unsigned three_stage_setup:1;
> @@ -1281,6 +1289,10 @@ struct dwc3 {
> unsigned dis_split_quirk:1;
>
> u16 imod_interval;
> +
> + int max_cfg_eps;
> + int last_fifo_depth;
> + int num_ep_resized;
> };
>
You document 4 new variables being added, but add 5 variables to the
structure. Something is out of sync :(
next prev parent reply other threads:[~2021-07-09 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 0:27 [PATCH v13 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-07-09 0:27 ` [PATCH v13 1/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-07-09 0:27 ` [PATCH v13 2/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-07-09 0:27 ` [PATCH v13 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-07-09 5:41 ` Greg KH [this message]
2021-07-09 0:27 ` [PATCH v13 4/6] of: Add stub for of_add_property() Wesley Cheng
2021-07-09 0:27 ` [PATCH v13 5/6] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-07-09 0:27 ` [PATCH v13 6/6] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOfhg9FK8y72A/mw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fntoth@gmail.com \
--cc=frowand.list@gmail.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®