From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E94C07E9E for ; Fri, 9 Jul 2021 08:27:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B22B613CA for ; Fri, 9 Jul 2021 08:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbhGII3w (ORCPT ); Fri, 9 Jul 2021 04:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231361AbhGII3u (ORCPT ); Fri, 9 Jul 2021 04:29:50 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 464D8C0613E6 for ; Fri, 9 Jul 2021 01:27:07 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id a2so9225186pgi.6 for ; Fri, 09 Jul 2021 01:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yU9Twe5lXj23b1mNka/5xOrpyF7ZSTRqoQCTkjEokB4=; b=LIfVVMZPNUHjO9GLLsf57mvnfsctNvpBsj6fgEhwtEMYU2QPQ6BXihMW4SZkVW2q16 Qxmr/bSKL2oMkgNy53y7JgditJt9aOU8Cd84q4+Vrqw63I36+wpNdi9w+PutgmATOf8b 7XabHAsqBzIS7zS4SnDN9sLqcex4HGp2Xy17w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yU9Twe5lXj23b1mNka/5xOrpyF7ZSTRqoQCTkjEokB4=; b=ZsKGXeWaO4BJ/qykOEgN0t5PK8FOpxzH+78e7gr0aiQEBJzKVnIBhlNkYpXwFNQ8eM f4n3jAMVxvP0DMx1cqHYbfT3mmsltGrp1t8Y9HNjkAlYTGWez0mEkMMgT9lC5VxvIaKf R1enGVwtH3rpogyMTWlnQdNUuRslfZRgGZLPVDPeRIHbZn3RKQLwU6WjFfDcOL9VRr7f +1Y4M02tLoFIv4th232h3sbZJDdZ2WVd92Kicz7rhohBHRqF/8xl4/QTGoG16oq8lYfX EqP+C9rz4J+jtAXr67I8zq3XWz2qYBDHd2AvAfSwRPy4zaQED7hyuIZIQYr6hdwyIPgC pRrw== X-Gm-Message-State: AOAM533K3jAt8DXMwdLg0P5ekmV4MEoMp+RZ/Wja+zR3eKqon8yWanrB bTXHCyhoBYHp9zf605Z/XaCvRA== X-Google-Smtp-Source: ABdhPJxk6FrpXb7jO30ZusT2cxQ16M60gq3kw3CbQwTLoJvyedQynzhdP7rkgXhS7oB7FCkbYSPS2A== X-Received: by 2002:a62:1750:0:b029:328:9c55:4f5b with SMTP id 77-20020a6217500000b02903289c554f5bmr3424022pfx.6.1625819226849; Fri, 09 Jul 2021 01:27:06 -0700 (PDT) Received: from chromium.org ([2401:fa00:8f:203:735b:c3cc:6957:ae6d]) by smtp.gmail.com with ESMTPSA id cx4sm4143678pjb.53.2021.07.09.01.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 01:27:06 -0700 (PDT) Date: Fri, 9 Jul 2021 17:27:02 +0900 From: Tomasz Figa To: Tzung-Bi Shih Cc: "kyrie.wu" , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Subject: Re: [PATCH v2,0/9] Support jpeg encode for MT8195 Message-ID: References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021 at 07:00:17PM +0800, Tzung-Bi Shih wrote: > On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu wrote: > > add component framework to using multi-HW for MT8195 jpeg encode. > Could you add some summary for each patch for getting an overview of the series? > > > dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible > > media: mtk-jpegenc: Add MT8195 JPEG venc driver > > media: mtk-jpegenc: remove redundant code of irq > > media: mtk-jpegenc: Refactor jpeg clock interface > > media: mtk-jpegenc: Generalize jpeg encode irq interfaces > > media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces > > media: mtk-jpegenc: Use component framework to manage each hardware > > information > > media: mtk-jpegenc: Generalize jpegenc HW operations interfaces > > media: mtk-jpegenc: Refactor jpegenc device run interface > The series has some consistency issues which would make readers feel > uncomfortable. > > For example: > - Whether to capitalize the first characters in the commit messages/titles. > - Whether to add a period at the end of English sentences. FWIW, it's not customary to add a period at the end of a patch subject. Best regards, Tomasz