From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C41C07E99 for ; Fri, 9 Jul 2021 09:07:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EC07613D6 for ; Fri, 9 Jul 2021 09:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231756AbhGIJKE (ORCPT ); Fri, 9 Jul 2021 05:10:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231573AbhGIJKA (ORCPT ); Fri, 9 Jul 2021 05:10:00 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E5A8C0613DD for ; Fri, 9 Jul 2021 02:07:17 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id g6-20020a17090adac6b029015d1a9a6f1aso6825966pjx.1 for ; Fri, 09 Jul 2021 02:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=M+M0yYUEtZSkXRq1SttoHZPElhf5y1HWt6Uqd2WPOVvykCW2uMKJo+dWqB/b7T/uAQ fjosM8Kqi5f4SzbPGwYgm4oKpWD1wzaolrW0tjV2nOJFb+dnjxqqmOLl52TBqBzgacFW P0+adWQQUibpuf3s3sD9DAyLwdemH1TUc3jSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=j2M0gL/bauQsFaiscDmCfIsawVw0I8G0R3eZRSmpPtppqza2DIo5pNhVXUdwrG5J9p gOa5hETaaotBBTGzf0Gen/KYDFshvyNTeGjVsfSYqz2kC8SrqTMLfoptxwVXntG/OZAo 5f2s0yYXWYD+tWcmrwREylSWI823kkdJ8+wS5xO7RwuIiGMvXeRm9YLCsg0/UhYvpkkR dmsPbubw+WBygzwjDvvXVKuWXMCCqB8pQl/HLDnhFIUBbGXsegaBTZdYi7MjgMfYSIqm ZYHFp4Xh02SKOMLevsXjgFMo48GVwU7cVwnfNpBjuTiWoaWydSJT/E/7nEXqWu5W4H2u Mu2g== X-Gm-Message-State: AOAM532YEarVgmE7hk+fJhq6AgJcfzxFjBbThsbqxeZ56PxAl261w5Td Wy8mWi3yds2PeGTwhTeTBJJ7jQ== X-Google-Smtp-Source: ABdhPJz4I0POPOVj3Wkh8i4WXpamcrEJC3Grht7ICVEj/onjcRzdIfX2RaRoNse5+ehpA/w95ZtaNA== X-Received: by 2002:a17:90a:4595:: with SMTP id v21mr9612932pjg.202.1625821636697; Fri, 09 Jul 2021 02:07:16 -0700 (PDT) Received: from chromium.org ([2401:fa00:8f:203:735b:c3cc:6957:ae6d]) by smtp.gmail.com with ESMTPSA id 21sm4831945pfh.103.2021.07.09.02.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 02:07:16 -0700 (PDT) Date: Fri, 9 Jul 2021 18:07:11 +0900 From: Tomasz Figa To: Tzung-Bi Shih Cc: "kyrie.wu" , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Subject: Re: [PATCH v2,3/9] media: mtk-jpegenc: remove redundant code of irq Message-ID: References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> <1625038079-25815-4-git-send-email-kyrie.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021 at 07:00:33PM +0800, Tzung-Bi Shih wrote: > On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu wrote: > > the func of jpgenc irq handler would not compatible, remove those > > code. > Need more explanation about why as I believe it is non-backward compatible. Right. And it breaks bisection, which is not acceptable. Kyrie, please structure your series in a way that none of the patches break any existing functionality. Best regards, Tomasz