mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shaobo Huang <huangshaobo6@huawei.com>
Cc: chenzefeng2@huawei.com, kepler.chenxin@huawei.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	liucheng32@huawei.com, mhiramat@kernel.org,
	nixiaoming@huawei.com, tixy@linaro.org, xiaoqian9@huawei.com,
	young.liuyang@huawei.com, zengweilin@huawei.com
Subject: Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping
Date: Fri, 9 Jul 2021 15:06:56 +0200	[thread overview]
Message-ID: <YOhJ8KaoH4BU3ej1@kroah.com> (raw)
In-Reply-To: <20210709024630.22268-1-huangshaobo6@huawei.com>

On Fri, Jul 09, 2021 at 10:46:30AM +0800, Shaobo Huang wrote:
> From: Masami Hiramatsu <mhiramat@kernel.org>
> 
> commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream
> 
> This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to
> handle reentered kprobe on single-stepping")
> 
> Since the FIQ handlers can interrupt in the single stepping
> (or preparing the single stepping, do_debug etc.), we should
> consider a kprobe is hit in the NMI handler. Even in that
> case, the kprobe is allowed to be reentered as same as the
> kprobes hit in kprobe handlers
> (KPROBE_HIT_ACTIVE or KPROBE_HIT_SSDONE).
> 
> The real issue will happen when a kprobe hit while another
> reentered kprobe is processing (KPROBE_REENTER), because
> we already consumed a saved-area for the previous kprobe.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Jon Medhurst <tixy@linaro.org>
> Fixes: 24ba613c9d6c ("ARM kprobes: core code")
> Cc: stable@vger.kernel.org #v2.6.25~v4.11
> Signed-off-by: huangshaobo <huangshaobo6@huawei.com>
> ---
>  arch/arm/probes/kprobes/core.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Now queued up, thanks.

greg k-h

      parent reply	other threads:[~2021-07-09 13:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27  9:17 huangshaobo
2021-02-27 10:50 ` Shaobo Huang
2021-03-01 11:30 ` Greg KH
2021-03-02  1:24   ` Shaobo Huang
2021-07-08 12:42     ` ping // " Shaobo Huang
2021-07-08 12:55       ` Greg KH
2021-07-08 13:12         ` Shaobo Huang
2021-07-08 14:40           ` Greg KH
2021-07-09  2:46             ` Shaobo Huang
2021-07-09  9:00               ` Masami Hiramatsu
2021-07-09 11:39                 ` Xiaoming Ni
2021-07-09 15:33                   ` Masami Hiramatsu
2021-07-09 13:06               ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOhJ8KaoH4BU3ej1@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chenzefeng2@huawei.com \
    --cc=huangshaobo6@huawei.com \
    --cc=kepler.chenxin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liucheng32@huawei.com \
    --cc=mhiramat@kernel.org \
    --cc=nixiaoming@huawei.com \
    --cc=tixy@linaro.org \
    --cc=xiaoqian9@huawei.com \
    --cc=young.liuyang@huawei.com \
    --cc=zengweilin@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome