From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=BAYES_00,DKIM_ADSP_NXDOMAIN, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092C0C07E9A for ; Mon, 12 Jul 2021 20:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4439611B0 for ; Mon, 12 Jul 2021 20:27:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236696AbhGLUaB (ORCPT ); Mon, 12 Jul 2021 16:30:01 -0400 Received: from fgw20-7.mail.saunalahti.fi ([62.142.5.81]:50073 "EHLO fgw20-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234982AbhGLUaA (ORCPT ); Mon, 12 Jul 2021 16:30:00 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 87ea98c9-e34f-11eb-ba24-005056bd6ce9; Mon, 12 Jul 2021 23:27:10 +0300 (EEST) Date: Mon, 12 Jul 2021 23:27:08 +0300 From: andy@surfacebook.localdomain To: Vignesh Raghavendra Cc: Jan Kiszka , Tony Lindgren , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, Linux ARM Mailing List , linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250: 8250_omap: Fix possible interrupt storm Message-ID: References: <20210511151955.28071-1-vigneshr@ti.com> <0ad948ac-f669-3d6d-5eca-4ca48d47d6a3@siemens.com> <56c5d73f-741c-2643-1c79-6dc13ebb05c7@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56c5d73f-741c-2643-1c79-6dc13ebb05c7@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Jun 22, 2021 at 11:53:38AM +0530, Vignesh Raghavendra kirjoitti: > On 6/22/21 11:45 AM, Jan Kiszka wrote: > >>> Vignesh, it seems this quirk needs some soc specific flag added to > >>> it maybe? Or maybe UART_OMAP_RX_LVL register is not available for > >>> all the SoCs? > >>> > >> Yes indeed :( > >> > >>> I think it's best to drop this patch until the issues are resolved, > >>> also there are some open comments above that might be answered by > >>> limiting this quirk to a specific range of SoCs :) > >>> > >> Oops, I did test patch AM33xx assuming its equivalent to OMAP3, but UART > >> IP is quite different. I will respin the patch making sure, workaround > >> applies only to AM65x and K3 SoCs. > >> > >> Regards > >> Vignesh > >> > > What's the status here for AM65x? The issue remains present on that > > platform, and I was hoping to see a quick follow up that limit the fix > > to that target. > > Sorry for the delay, I am trying to find which other TI SoCs are > affected by this issue. But that exercise will need a bit more time. > Will send a fix to address K3 SoCs like AM65x today/tomo. This all reminds me the very similar issue one found on Intel integrated (Synopsys DesignWare based) UARTs: https://lore.kernel.org/linux-serial/20170206233000.3021-1-dianders@chromium.org/ https://lore.kernel.org/linux-serial/1440015124-28393-1-git-send-email-california.l.sullivan@intel.com/ -- With Best Regards, Andy Shevchenko