From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42824C07E9B for ; Wed, 21 Jul 2021 08:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C58E60FDA for ; Wed, 21 Jul 2021 08:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236059AbhGUHqs (ORCPT ); Wed, 21 Jul 2021 03:46:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:45762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235831AbhGUHjB (ORCPT ); Wed, 21 Jul 2021 03:39:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 12A1760725; Wed, 21 Jul 2021 08:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626855575; bh=rSPMcqavfaZHJaVAoTYpAUv/15YqukMFmRLnFN5hDns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K0/gD1mRnrfhmRCmDq+D658f+DH4AoV7oBRyJnvhus33WWabIjAnsF+zxhHetVSBu LT+uB7YWGDZ5XDP3pc7dEKaV1uulupmJFrXrwPZhULQVHeeuRjpnnzbCHUK1GO4QPe 7GGhpaU8kKEvNdiivk2YE8466cic/DCR0FtcrBr4= Date: Wed, 21 Jul 2021 10:19:33 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Larry Finger , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8188eu: Remove an unused variable and some lines of code Message-ID: References: <20210705134151.15143-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210705134151.15143-1-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 05, 2021 at 03:41:51PM +0200, Fabio M. De Francesco wrote: > Remove set but unused iw_operation_mode[]. This driver doesn't support > SIOCSIWRATE. It just returns zero and does nothing. Change it to > return -ENOTSUPP instead. (This is an API change but we don't expect it > to break anything). > > Suggested-by: Dan Carpenter > Signed-off-by: Fabio M. De Francesco > --- > > v1->v2: Delete rtw_wx_set_rate() and its association with command > SIOCSIWRATE as suggested by Dan Carpenter Does not apply to my tree :(